Skip to content

Commit ac08030

Browse files
author
Mihailo Markovic
committed
Changed typeReachable conditions into typeReached.
1 parent b0bbc22 commit ac08030

File tree

4 files changed

+2
-127
lines changed

4 files changed

+2
-127
lines changed

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/InclusionCondition.java

Lines changed: 0 additions & 81 deletions
This file was deleted.

sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeReachabilityCondition.java

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242

4343
import java.util.Objects;
4444

45-
<<<<<<<< HEAD:sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeReachabilityCondition.java
4645
import org.graalvm.nativeimage.hosted.RegistrationCondition;
4746

4847
/**
@@ -54,19 +53,6 @@ public class TypeReachabilityCondition implements RegistrationCondition {
5453

5554
/* Cached to save space: it is used as a marker for all non-conditional elements */
5655
public static final TypeReachabilityCondition JAVA_LANG_OBJECT_REACHED = new TypeReachabilityCondition(Object.class, true);
57-
========
58-
import org.graalvm.nativeimage.hosted.InclusionCondition;
59-
60-
/**
61-
* Type that represents both type-reached and type-reachable condition. When
62-
* {@link TypeCondition#runtimeChecked} is <code>true</code> denotes that this is a
63-
* <code>typeReached</code> condition.
64-
*/
65-
public class TypeCondition implements InclusionCondition {
66-
67-
/* Cached to save space: it is used as a marker for all non-conditional elements */
68-
public static final TypeCondition JAVA_LANG_OBJECT_REACHED = new TypeCondition(Object.class, true);
69-
>>>>>>>> 675ac0bf8ee (Introduced public API for registration conditions.):sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeCondition.java
7056
private final Class<?> type;
7157

7258
public final boolean runtimeChecked;
@@ -79,7 +65,6 @@ public class TypeCondition implements InclusionCondition {
7965
* @param runtimeChecked makes this a type-reachable condition when false
8066
* @return instance of the condition
8167
*/
82-
<<<<<<<< HEAD:sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeReachabilityCondition.java
8368
public static TypeReachabilityCondition create(Class<?> type, boolean runtimeChecked) {
8469
Objects.requireNonNull(type);
8570
if (TypeReachabilityCondition.JAVA_LANG_OBJECT_REACHED.getKey().equals(type)) {
@@ -93,21 +78,6 @@ public boolean isAlwaysTrue() {
9378
}
9479

9580
public TypeReachabilityCondition(Class<?> type, boolean runtimeChecked) {
96-
========
97-
public static TypeCondition create(Class<?> type, boolean runtimeChecked) {
98-
Objects.requireNonNull(type);
99-
if (TypeCondition.JAVA_LANG_OBJECT_REACHED.getKey().equals(type)) {
100-
return TypeCondition.JAVA_LANG_OBJECT_REACHED;
101-
}
102-
return new TypeCondition(type, runtimeChecked);
103-
}
104-
105-
public boolean isAlwaysTrue() {
106-
return InclusionCondition.alwaysInclude().equals(this);
107-
}
108-
109-
public TypeCondition(Class<?> type, boolean runtimeChecked) {
110-
>>>>>>>> 675ac0bf8ee (Introduced public API for registration conditions.):sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeCondition.java
11181
this.runtimeChecked = runtimeChecked;
11282
this.type = type;
11383
}
@@ -124,11 +94,7 @@ public boolean equals(Object o) {
12494
if (o == null || getClass() != o.getClass()) {
12595
return false;
12696
}
127-
<<<<<<<< HEAD:sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeReachabilityCondition.java
12897
TypeReachabilityCondition that = (TypeReachabilityCondition) o;
129-
========
130-
TypeCondition that = (TypeCondition) o;
131-
>>>>>>>> 675ac0bf8ee (Introduced public API for registration conditions.):sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeCondition.java
13298
return runtimeChecked == that.runtimeChecked && Objects.equals(type, that.type);
13399
}
134100

@@ -139,11 +105,7 @@ public int hashCode() {
139105

140106
@Override
141107
public String toString() {
142-
<<<<<<<< HEAD:sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeReachabilityCondition.java
143108
return "TypeReachabilityCondition(" +
144-
========
145-
return "TypeCondition(" +
146-
>>>>>>>> 675ac0bf8ee (Introduced public API for registration conditions.):sdk/src/org.graalvm.nativeimage/src/org/graalvm/nativeimage/impl/TypeCondition.java
147109
"type=" + type +
148110
", runtimeChecked=" + runtimeChecked +
149111
')';

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/reflect/NativeImageConditionResolver.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,7 @@ public TypeResult<RegistrationCondition> resolveCondition(UnresolvedConfiguratio
5353
* reachability checks.
5454
*/
5555
var runtimeChecked = !classInitializationSupport.isAlwaysReached(type) && unresolvedCondition.isRuntimeChecked();
56-
/*
57-
* GR-62516, this should be deleted
58-
*/
56+
/* This condition might be typeReachable */
5957
return TypeReachabilityCondition.create(type, runtimeChecked);
6058
});
6159
}

substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/reflect/ReflectionDataBuilder.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -650,11 +650,7 @@ private void processAnnotationMethod(boolean queriedOnly, Method method) {
650650
Class<?> annotationClass = method.getDeclaringClass();
651651
Class<?> proxyClass = Proxy.getProxyClass(annotationClass.getClassLoader(), annotationClass);
652652
try {
653-
/*
654-
* build-time condition as it is registered during analysis GR-62516, this should be
655-
* deleted
656-
*/
657-
var condition = TypeReachabilityCondition.create(proxyClass, false);
653+
var condition = RegistrationCondition.always();
658654
register(condition, queriedOnly, proxyClass.getDeclaredMethod(method.getName(), method.getParameterTypes()));
659655
} catch (NoSuchMethodException e) {
660656
/*

0 commit comments

Comments
 (0)