Skip to content

Commit e4b9a0e

Browse files
committed
[GR-60602] Remove libraries from the native-image layer building test exclude list
PullRequest: graal/19650
2 parents 068def2 + c3cfc98 commit e4b9a0e

File tree

3 files changed

+28
-50
lines changed

3 files changed

+28
-50
lines changed

.github/workflows/ni-layers.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,11 @@ on:
4444
push:
4545
paths:
4646
- '.github/workflows/ni-layers.yml'
47+
- 'vm/tests/gh_workflows/NILayerTests/**'
4748
pull_request:
4849
paths:
4950
- '.github/workflows/ni-layers.yml'
51+
- 'vm/tests/gh_workflows/NILayerTests/**'
5052
schedule:
5153
- cron: "0 0 * * 1" # Once a week, at midnight on Monday (00:00 UTC)
5254
workflow_dispatch:

vm/tests/gh_workflows/NILayerTests/build_native_image_layer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def build_layers(native_image_path, coordinates, delimiter):
9696
currDir = os.getcwd()
9797
group_id, artifact_id, version = gav.rstrip().split(':')
9898

99-
subprocess.run(['mvn', 'dependency:get', f'-Dartifact={gav}', '-Dtransitive=true'])
99+
subprocess.run(['mvn', '-B', 'dependency:get', f'-Dartifact={gav}', '-Dtransitive=true'])
100100

101101
library_path = os.path.join(Path.home(), '.m2', 'repository', group_id.replace('.','/'), artifact_id, version)
102102
jar_path = os.path.join(library_path, f'{artifact_id}-{version}.jar')
@@ -114,10 +114,10 @@ def build_layers(native_image_path, coordinates, delimiter):
114114
'-J-ea', '-J-esa',
115115
'--no-fallback',
116116
'-cp' ,f'{jar_path}:{dependency_path}',
117-
'-o', f'{artifact_id}-{version}'
118117
'-H:+UnlockExperimentalVMOptions',
119118
f'-H:LayerCreate=layer.nil,path={jar_path}',
120119
'-H:+ReportExceptionStackTraces',
120+
'-o', f'{artifact_id}-{version}'
121121
]
122122
print(f'Command: {' '.join(command)}')
123123
subprocess.run(command, check=True)

vm/tests/gh_workflows/NILayerTests/excluded-popular-maven-libraries.json

Lines changed: 24 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,17 @@
55
"version": "4.0.22",
66
"reason": "Library too large to be built in a GitHub action. Finishes generating on better systems locally"
77
},
8-
{
9-
"group_id": "org.apache.logging.log4j",
10-
"artifact_id": "log4j-core",
11-
"version": "2.24.0",
12-
"reason": "GR-57711"
13-
},
148
{
159
"group_id": "org.scalatest",
1610
"artifact_id": "scalatest_3",
1711
"version": "3.2.19",
1812
"reason": "[Maven ERROR] Unknown packaging: bundle"
1913
},
20-
{
21-
"group_id": "org.springframework.boot",
22-
"artifact_id": "spring-boot-autoconfigure",
23-
"version": "3.3.3",
24-
"reason": "GR-57738"
25-
},
2614
{
2715
"group_id": "com.alibaba.fastjson2",
2816
"artifact_id": "fastjson2",
2917
"version": "2.0.52",
30-
"reason": "GR-57711"
18+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
3119
},
3220
{
3321
"group_id": "org.scala-js",
@@ -69,13 +57,7 @@
6957
"group_id": "org.playframework",
7058
"artifact_id": "play-test_3",
7159
"version": "3.0.5",
72-
"reason": "GR-57711"
73-
},
74-
{
75-
"group_id": "io.quarkus",
76-
"artifact_id": "quarkus-junit5",
77-
"version": "3.14.3",
78-
"reason": "GR-57711"
60+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
7961
},
8062
{
8163
"group_id": "nl.jqno.equalsverifier",
@@ -137,30 +119,18 @@
137119
"version": "2.3.0",
138120
"reason": "[Maven ERROR] Unknown packaging: bundle"
139121
},
140-
{
141-
"group_id": "org.gwtproject",
142-
"artifact_id": "gwt-user",
143-
"version": "2.11.0",
144-
"reason": "GR-57738"
145-
},
146122
{
147123
"group_id": "io.vertx",
148124
"artifact_id": "vertx-core",
149125
"version": "4.5.10",
150-
"reason": "GR-57711"
126+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
151127
},
152128
{
153129
"group_id": "org.mariadb.jdbc",
154130
"artifact_id": "mariadb-java-client",
155131
"version": "3.4.1",
156132
"reason": "Finishes generating, but requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
157133
},
158-
{
159-
"group_id": "com.microsoft.sqlserver",
160-
"artifact_id": "mssql-jdbc",
161-
"version": "12.8.1.jre11",
162-
"reason": "GR-57711"
163-
},
164134
{
165135
"group_id": "com.fasterxml.jackson.dataformat",
166136
"artifact_id": "jackson-dataformat-cbor",
@@ -203,12 +173,6 @@
203173
"version": "3.5.2",
204174
"reason": "GR-57816"
205175
},
206-
{
207-
"group_id": "org.springframework.security",
208-
"artifact_id": "spring-security-web",
209-
"version": "6.3.3",
210-
"reason": "GR-57738"
211-
},
212176
{
213177
"group_id": "org.eclipse.paho",
214178
"artifact_id": "org.eclipse.paho.client.mqttv3",
@@ -279,13 +243,13 @@
279243
"group_id": "org.jline",
280244
"artifact_id": "jline",
281245
"version": "3.26.3",
282-
"reason": "GR-57711"
246+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
283247
},
284248
{
285249
"group_id": "org.flywaydb",
286250
"artifact_id": "flyway-core",
287251
"version": "10.17.3",
288-
"reason": "GR-57711"
252+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
289253
},
290254
{
291255
"group_id": "org.springmodules",
@@ -305,12 +269,6 @@
305269
"version": "3.5.2",
306270
"reason": "GR-57816"
307271
},
308-
{
309-
"group_id": "org.apache.cassandra",
310-
"artifact_id": "java-driver-core",
311-
"version": "4.18.1",
312-
"reason": "GR-57711"
313-
},
314272
{
315273
"group_id": "org.apache.hadoop",
316274
"artifact_id": "hadoop-hdfs",
@@ -333,7 +291,7 @@
333291
"group_id": "org.apache.hbase",
334292
"artifact_id": "hbase-client",
335293
"version": "2.6.0",
336-
"reason": "GR-57711"
294+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
337295
},
338296
{
339297
"group_id": "io.circe",
@@ -346,5 +304,23 @@
346304
"artifact_id": "cats-effect_3",
347305
"version": "3.6-0142603",
348306
"reason": "GR-59420"
307+
},
308+
{
309+
"group_id": "org.apache.cassandra",
310+
"artifact_id": "java-driver-core",
311+
"version": "4.18.1",
312+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
313+
},
314+
{
315+
"group_id": "com.microsoft.sqlserver",
316+
"artifact_id": "mssql-jdbc",
317+
"version": "12.8.1.jre11",
318+
"reason": "GR-57711, also requires user 'initialize-at-build-time' and 'initialize-at-run-time' input"
319+
},
320+
{
321+
"group_id": "io.quarkus",
322+
"artifact_id": "quarkus-junit5",
323+
"version": "3.14.3",
324+
"reason": "GR-57711"
349325
}
350326
]

0 commit comments

Comments
 (0)