Skip to content

[GR-64784] Enable serialization for the preserve mode. #11236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.graalvm.nativeimage.impl.RuntimeJNIAccessSupport;
import org.graalvm.nativeimage.impl.RuntimeProxyCreationSupport;
import org.graalvm.nativeimage.impl.RuntimeReflectionSupport;
import org.graalvm.nativeimage.impl.RuntimeSerializationSupport;

import com.oracle.graal.pointsto.ClassInclusionPolicy;
import com.oracle.svm.core.SubstrateOptions;
Expand Down Expand Up @@ -152,6 +153,7 @@ public static void registerPreservedClasses(NativeImageClassLoaderSupport classL
final RuntimeReflectionSupport reflection = ImageSingletons.lookup(RuntimeReflectionSupport.class);
final RuntimeJNIAccessSupport jni = ImageSingletons.lookup(RuntimeJNIAccessSupport.class);
final RuntimeProxyCreationSupport proxy = ImageSingletons.lookup(RuntimeProxyCreationSupport.class);
final RuntimeSerializationSupport<ConfigurationCondition> serialization = RuntimeSerializationSupport.singleton();
final ConfigurationCondition always = ConfigurationCondition.alwaysTrue();

/*
Expand Down Expand Up @@ -207,7 +209,7 @@ public static void registerPreservedClasses(NativeImageClassLoaderSupport classL
classesToPreserve.reversed().forEach(c -> {
reflection.registerAllFields(always, c);
reflection.registerAllMethodsQuery(always, false, c);
// RuntimeSerialization.register(c);
serialization.register(always, c);
});

for (String className : classLoaderSupport.getClassNamesToPreserve()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -554,15 +554,24 @@ public void registerAllDeclaredFields(ConfigurationCondition condition, Class<?>
registerAllDeclaredFieldsQuery(condition, false, clazz);
}

private record AllDeclaredFieldsQuery(ConfigurationCondition condition, boolean queriedOnly, Class<?> clazz) {
}

private Set<AllDeclaredFieldsQuery> existingAllDeclaredFieldsQuery = ConcurrentHashMap.newKeySet();

public void registerAllDeclaredFieldsQuery(ConfigurationCondition condition, boolean queriedOnly, Class<?> clazz) {
runConditionalInAnalysisTask(condition, (cnd) -> {
setQueryFlag(clazz, ALL_DECLARED_FIELDS_FLAG);
try {
registerFields(cnd, queriedOnly, clazz.getDeclaredFields());
} catch (LinkageError e) {
registerLinkageError(clazz, e, fieldLookupExceptions);
}
});
final var query = new AllDeclaredFieldsQuery(condition, queriedOnly, clazz);
if (!existingAllDeclaredFieldsQuery.contains(query)) {
runConditionalInAnalysisTask(condition, (cnd) -> {
setQueryFlag(clazz, ALL_DECLARED_FIELDS_FLAG);
try {
registerFields(cnd, queriedOnly, clazz.getDeclaredFields());
} catch (LinkageError e) {
registerLinkageError(clazz, e, fieldLookupExceptions);
}
});
existingAllDeclaredFieldsQuery.add(query);
}
}

private void registerFields(ConfigurationCondition cnd, boolean queriedOnly, Field[] reflectFields) {
Expand Down Expand Up @@ -1137,6 +1146,7 @@ protected void afterAnalysis() {
if (!throwMissingRegistrationErrors()) {
pendingRecordClasses = null;
}
existingAllDeclaredFieldsQuery = null;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,9 @@ private Constructor<?> newConstructorForSerialization(Class<?> serializationTarg
} else {
constructorToCall = customConstructorToCall;
}
if (constructorToCall == null) {
return null;
}
ConstructorAccessor acc = getConstructorAccessor(serializationTargetClass, constructorToCall);
JavaLangReflectAccess langReflectAccess = ReflectionUtil.readField(ReflectionFactory.class, "langReflectAccess", ReflectionFactory.getReflectionFactory());
Method newConstructorWithAccessor = ReflectionUtil.lookupMethod(JavaLangReflectAccess.class, "newConstructorWithAccessor", Constructor.class, ConstructorAccessor.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public static <T> Constructor<T> lookupConstructor(boolean optional, Class<T> de
openModule(declaringClass);
result.setAccessible(true);
return result;
} catch (ReflectiveOperationException | NoClassDefFoundError ex) {
} catch (ReflectiveOperationException | LinkageError ex) {
if (optional) {
return null;
}
Expand Down
Loading