Add ability to install custom JS module loaders. #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `JSModuleLoaderFactory` interface for ESM loader hook. - Adds `CommonJSResolverHook` interface for CJS resolver hook. - Adds `js.module-loader-factory=handler` setting to enable. - Adjusts `JSEngine` to retain the installed factory and/or resolver. - Adjusts `JSRealm` to use `JSEngine` to create the module loader. - Adjusts `NpmCompatibleESModuleLoader` to be extensible. - Adjusts `CommonJSResolution` to use the resolver hook if present. Relates to oracle/graal#9177 Signed-off-by: Sam Gammon <sam@elide.dev>
oracle-contributor-agreement
bot
added
the
OCA Verified
sgammon
commented
Feb 27, 2025
| @@ -169,6 +171,21 @@ protected static Object fallback(@SuppressWarnings("unused") Object function, Ob | |||
| @TruffleBoundary | |||
| private Object requireImpl(String moduleIdentifier, TruffleFile entryPath, JSRealm realm) { | |||
| log("required module '", moduleIdentifier, "' from path ", entryPath); | |||
| // 1.1 (Non-spec): If a module resolver hook has been installed, give it a chance to resolve the module, but | |||
| // only if `handler` mode is enabled for JS module resolution. | |||
| if (realm.getContextOptions().getModuleLoaderFactoryMode().equals(HANDLER)) { | |||
There was a problem hiding this comment.
should be HANDLER.equals(realm.getContextOptions().getModuleLoaderFactoryMode()) to avoid npe
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds hooks for Java embedders to inject module implementations for ESM and CJS.
oracle/graal#9177
Changelog
JSModuleLoaderFactoryinterface for ESM loader hook.CommonJSResolverHookinterface for CJS resolver hook.js.module-loader-factory=handlersetting to enable.JSEngineto retain the installed factory and/or resolver.JSRealmto useJSEngineto create the module loader.NpmCompatibleESModuleLoaderto be extensible.CommonJSResolutionto use the resolver hook if present.