Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor SourceCodeRepo heuristic #990

Open
art1f1c3R opened this issue Feb 13, 2025 · 0 comments
Open

refactor SourceCodeRepo heuristic #990

art1f1c3R opened this issue Feb 13, 2025 · 0 comments
Assignees
Labels
checks The issues related to Macaron checks malware analysis The issues related to malware analysis

Comments

@art1f1c3R
Copy link
Member

art1f1c3R commented Feb 13, 2025

Referencing the TODO item in #983:

Currently, the SourceCodeRepo heuristic still has a dependency on the EmptyProjectLinks heuristic. This is done currently to make the merging process easier, and to avoid a heavy rework of the SUSPICIOUS_COMBOS dictionary. This dictionary is expected to soon be replaced with a more usable alternative, at which time the combinations including this heuristic may be updated.

The SourceCodeRepo heuristic must be refactored to avoid a dependency on the EmptyProjectLinks, as these two heuristics are not closely related enough for this dependency. SourceCodeRepo tracks whether a repository was found, whereas EmptyProjectLinks tracks whether any project links are available on the PyPI page of the package.

@behnazh-w behnazh-w added checks The issues related to Macaron checks malware analysis The issues related to malware analysis labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checks The issues related to Macaron checks malware analysis The issues related to malware analysis
Projects
None yet
Development

No branches or pull requests

2 participants