Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation List component: Inconsistent focus styling #15

Open
jshields opened this issue Nov 3, 2016 · 1 comment
Open

Navigation List component: Inconsistent focus styling #15

jshields opened this issue Nov 3, 2016 · 1 comment

Comments

@jshields
Copy link

jshields commented Nov 3, 2016

All other JET components use this mixin for component focus:

@mixin oj-browser-focus-outline-approximation($outlineColor)
{
  outline: dotted 1px $outlineColor;       // used on most browsers
  outline: -webkit-focus-ring-color auto;  // used on chrome
}

(File: utilities/_oj.utilities.focus.scss)

However, the Navigation List is not consistent with this pattern:

/*Focus ring around  focused list item*/
.oj-navigationlist .oj-navigationlist-item.oj-focus-highlight {
    outline: dotted 1px $navigationListItemOutlineColorFocus; // Using dotted line for all browsers
    outline-offset: -1px;
}

(File: common/widgets/_oj.common.navigationlist.scss)

In order to maintain consistency, the Navigation List should be changed to follow the pattern of the other components.

@crmouli
Copy link

crmouli commented Apr 26, 2019

when outline is set to
outline: -webkit-focus-ring-color auto;
There used to be a focus ring truncation issue on chrome so used dotted line for chrome too. Need to find a solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants