Merge branch 'origin/master' into release/graal-vm/1.0

Author: ansalond

.gitignore

@@ -47,6 +47,7 @@ src/main/c/*/*.bc
 src/main/c/*/*.su
 src/main/c/*/extconf.h
 src/main/c/*/mkmf.log
+src/main/c/sulongmock/sulongmock.c
 src/main/c/truffleposix/truffleposix.o
 src/main/c/truffleposix/truffleposix.so
 src/main/c/truffleposix/truffleposix.dylib

3rd_party_licenses.txt

@@ -1,48 +1,15 @@
-      LICENSING INFORMATION
-===============================================================================
+                           LICENSING INFORMATION
+                                TruffleRuby
 
+===============================================================================
 
- LICENSES FOR THIRD-PARTY COMPONENTS 
+ LICENSES FOR THIRD-PARTY COMPONENTS
 
 The following sections contain licensing information for libraries that we have 
 included with the GraalVM Community Edition 1.0 source and components used to 
 test GraalVM Community Edition 1.0. We are thankful to all individuals that 
 have created these.
 The following software may be included in this product:
---------------------------------------------------------------------------------
-           pr-zlib
-License for pr-zlib
-
-This library is covered under the same license as zlib itself. For the text
-of the zlib license, please see http://zlib.net/zlib_license.html.
-
-....
-
-/* zlib.h -- interface of the 'zlib' general purpose compression library
-  version 1.2.11, January 15th, 2017
-
-  Copyright (C) 1995-2017 Jean-loup Gailly and Mark Adler
-
-  This software is provided 'as-is', without any express or implied
-  warranty.  In no event will the authors be held liable for any damages
-  arising from the use of this software.
-
-  Permission is granted to anyone to use this software for any purpose,
-  including commercial applications, and to alter it and redistribute it
-  freely, subject to the following restrictions:
-
-  1. The origin of this software must not be misrepresented; you must not
-     claim that you wrote the original software. If you use this software
-     in a product, an acknowledgment in the product documentation would be
-     appreciated but is not required.
-  2. Altered source versions must be plainly marked as such, and must not be
-     misrepresented as being the original software.
-  3. This notice may not be removed or altered from any source distribution.
-
-  Jean-loup Gailly        Mark Adler
-  jloup@gzip.org          madler@alumni.caltech.edu
-
-*/
 --------------------------------------------------------------------------------
 
            Ruby

CHANGELOG.md

@@ -1,5 +1,31 @@
 # 1.0 RC 2, May 2018
 
+# 1.0 RC 3
+
+New features:
+
+* `is_a?` can be called on foreign objects.
+
+Bug fixes:
+
+* It is no longer needed to have `ruby` in `$PATH` to run the post-install hook.
+* `Qnil`/`Qtrue`/`Qfalse`/`Qundef` can now be used as initial value for global
+  variables in C extensions.
+* Fixed error message when the runtime libssl has no SSLv2 support (on Ubuntu
+  16.04 for instance).
+* `RbConfig::CONFIG['extra_bindirs']` is now a String as other RbConfig values.
+* `SIGPIPE` is correctly caught on SubstrateVM, and the corresponding write()
+  raises `Errno::EPIPE` when the read end of a pipe or socket is closed.
+
+Performance:
+
+* Faster stat()-related calls, by returning the relevant field directly and
+  avoiding extra allocations.
+* `rb_str_new()`/`rb_str_new_cstr()` are much faster by avoiding extra copying and
+  allocations.
+
+# 1.0 RC 2, May 2018
+
 New features:
 
 * We are now compatible with Ruby 2.4.4.
@@ -26,6 +52,8 @@ New features:
 Changes:
 
 * The version string now mentions `GraalVM CE` or `EE`.
+* The version string now mentions if you're running GraalVM Community Edition
+  (`GraalVM CE`) or GraalVM Enterprise Edition (`GraalVM EE`).
 
 * The inline JavaScript functionality `-Xinline_js` has been removed.
 

ci.jsonnet

@@ -240,8 +240,8 @@ local part_definitions = {
         ["mx", "fetch-languages", "--language:llvm", "--language:ruby"],
         # aot-build.log is used for the build-stats metrics
         [
-          "./native-image",
-          "--no-server",
+          "mx",
+          "native-image",
           "--language:ruby",
           "-H:Path=$SVM_HOME/svmbuild/native-image-root/languages/ruby/bin",
           "-H:Name=truffleruby",
@@ -293,9 +293,12 @@ local part_definitions = {
       downloads+: {
         JAVA_HOME: {
           name: "oraclejdk",
-          version: "10+46",       // 46 is the GA of Java 10
+          version: "10+46", # 46 is the GA of Java 10
           platformspecific: true,
         },
+
+        # We need a JDK 8 to compile TruffleRuby
+        EXTRA_JAVA_HOMES: $.jdk.labsjdk8.downloads["JAVA_HOME"],
       },
 
       environment+: {
@@ -729,7 +732,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "
 
   release_builds:
     {
-      local shared = $.use.common + { timelimit: "35:00" },
+      local shared = $.use.common + { timelimit: "40:00" },
       "ruby-test-standalone-distribution": $.platform.linux + $.cap.gate + $.jdk.openjdk8 + shared + $.run.test_make_standalone_distribution,
       "ruby-standalone-distribution-linux": $.platform.linux + $.cap.manual + $.jdk.openjdk8 + shared + $.run.make_standalone_distribution,
       "ruby-standalone-distribution-darwin": $.platform.darwin + $.cap.manual + $.jdk.labsjdk8 + shared + $.run.make_standalone_distribution,

doc/contributor/docker.md

@@ -24,10 +24,12 @@ Fedora 25 using RVM:
 $ jt docker print --fedora25 --source --rvm
 ```
 
-Or, to run a full set of tests on a new release candidate:
+Or, to run a full set of tests on a set of new release candidate tarballs:
 
 ```
-$ jt docker test --graalvm graalvm.tar.gz ruby.jar --test release_branch
+$ jt docker test --graalvm graalvm-ce.tar.gz ruby-installable.jar --test release_branch
+$ jt docker test --graalvm graalvm-ee.tar.gz ruby-installable.jar --test release_branch
+$ jt docker test --graalvm graalvm-ee.tar.gz ruby-installable.jar --rebuild-images --test release_branch
 ```
 
 ## Distributions
@@ -42,8 +44,9 @@ Pick one of:
 
 Pick one of:
 
-* From the public GraalVM CE binary tarball, and the public Ruby component, `--public 1.0.0rc-1` (default)
+* From the public GraalVM CE binary tarball, and the public Ruby component, `--public 1.0.0` (default)
 * From a GraalVM binary tarball and Ruby component you have locally, `--graalvm graalvm.tar.gz ruby-installable.jar`
+* From a TruffleRuby standalone distribution you have locally, `--standalone truffleruby-1.0.0-linux-amd64.tar.gz`
 * From source, `--source master`
 
 ## Ruby manager
@@ -69,9 +72,15 @@ Pick any of:
 * Rebuild images after installing the Ruby component, `--rebuild-images`
 * Run a full set of Docker tests we care about, `test` instead of `build`
 * Use a custom TruffleRuby repo, `--repo url`
+* Do not rebuild `openssl`, to test error messages, `--no-rebuild-openssl`
 
 When using `test` you need to specify the method of installing, and what to do.
 
+## Extracting a standalone image
+
+To extract a standalone image, use `jt docker extract-standalone ~/Downloads/ruby-installable-linux-amd64-rc2.jar 1.0.0-rc2`.
+The file name needs to have the platform in it, as it is on GitHub.
+
 ## Docker cache
 
 You may find that the Docker cache interacts badly with these Dockerfiles (such

doc/contributor/extensions-in-gems.md

@@ -417,6 +417,16 @@ looks at the underlying Java object.
 `object.to_str` will try to `UNBOX` the object and return it if it's a `String`,
 or will raise `NoMethodError` if it isn't.
 
+`java_object.is_a?(java_class)` does `java_object instanceof java_class`, using
+the host object instance, rather than any runtime interop wrapper.
+
+`object.is_a?(java_class)` does `object instanceof java_class`, using the
+runtime object instance.
+
+`foreign_object.is_a?(ruby_class)` returns `false`.
+
+`foreign_object.is_a?(foreign_class)` raises a `TypeError`.
+
 `object.respond_to?(:to_a)`, `respond_to?(:to_ary)` and `respond_to?(:size)`
 sends `HAS_SIZE`.
 
@@ -426,14 +436,12 @@ sends `HAS_SIZE`.
 
 `object.respond_to?(:class)` calls `Truffle::Interop.java_class?(object)`.
 
-`object.respond_to?(name)` for other names returns `false`.
-
-`object.respond_to?(:inspect)` is `true`.
-
-`object.respond_to?(:to_s)` is `true`.
+`object.respond_to?(:inspect)`, `:to_s`, `:is_a?`, is `true`.
 
 `object.respond_to?(:to_str)` is `true` if the object `UNBOXes` to a `String`.
 
+`object.respond_to?(name)` for other names returns `false`.
+
 `object.__send__(name, *args)` works in the same way as literal method call on
 the foreign object, including allowing the special-forms listed above (see
 [notes on method resolution](#notes-on-method-resolution)).
@@ -509,6 +517,8 @@ type is supported for interop.
 
 `Truffle::Interop.java_class?(object)`
 
+`Truffle::Interop.java_instanceof?(object, class)`
+
 `Truffle::Interop.java_string?(object)`
 
 `Truffle::Interop.to_java_string(ruby_string)`

doc/contributor/interop.md

@@ -0,0 +1,11 @@
+# Assumptions Third Party Code Makes About TruffleRuby
+
+When third-party code starts to make assumptions about the way TruffleRuby does
+something, such as a `TruffleRuby` method, or the layout of our distribution, we
+record it here so that we know who is using it if we need to change something
+about it.
+
+## TruffleRuby Extensions in Gems
+
+* `concurrent-ruby` using `TruffleRuby.full_memory_barrier` (actually it is using
+  `Truffle::System.full_memory_barrier` - need to update).

doc/contributor/third-party-assumptions.md

@@ -135,24 +135,6 @@ disabled where we dynamically detect that they probably won't be used. See the
 
 ## C Extension Compatibility
 
-#### Identifiers may be macros or functions
-
-Identifiers which are normally macros may be functions, functions may be macros,
-and global variables may be macros. This causes problems where they are used in
-a context which relies on a particular implementation, for example a global
-variable assigned to an initial value which was a macro, like `Qnil`, which is
-a macro that evaluates to a function call in TruffleRuby.
-
-For example, this global variable definition does not work because `Qnil` expands
-to be a function call in TruffleRuby:
-
-```c
-static VALUE foo = Qnil;
-```
-
-A workaround is to assign `foo` in your C extension `Init_` function, or inside
-some other function.
-
 #### Storing Ruby objects in native structures and arrays
 
 You cannot store a Ruby object in a structure or array that has been natively
@@ -176,6 +158,15 @@ but they cannot contain both in the same program run. If you have a global you
 assign `NULL` to (`NULL` being just `0` and so a native address) you cannot
 then assign managed data to this variable.
 
+#### Identifiers may be macros or functions
+
+Identifiers which are normally macros may be functions, functions may be macros,
+and global variables may be macros. This may cause problems where they are used
+in a context which relies on a particular implementation (e.g., taking the
+address of it, assigning to a function pointer variable and using defined() to
+check if a macro exists). These issues should all be considered bugs and be
+fixed, please report these cases.
+
 #### Variadic functions
 
 Variadic arguments of type `VALUE` that hold Ruby objects can be used, but they

doc/user/compatibility.md

@@ -1,10 +1,12 @@
 # Installing `libssl`
 
 TruffleRuby provides the `openssl` module but not the native `libssl` system
-library that the module uses. TruffleRuby requires version 1.0.2.
+library that the module uses. TruffleRuby supports both versions 1.0.2 and 1.1.0.
 
-Version 1.1.0 or more recent is incompatible, so you might need to install a
-compatibility version of `libssl`.
+If you experience `openssl`-related errors, it might help to recompile the
+`openssl` module by running `lib/truffle/post_install_hook.sh`.
+This is done automatically by Ruby managers, and mentioned in the post-install
+message when installing TruffleRuby via `gu install` in GraalVM.
 
 ## Oracle Linux
 
@@ -18,27 +20,22 @@ sudo yum install openssl-devel
 apt-get install libssl-dev
 ```
 
-We recommend `libssl-dev` instead of `libssl1.0.0`, even though we aren't using
-it for development because the latter doesn't seem to put the shared library in
-a place where we can find it.
+After installing GraalVM and Ruby you will need to rebuild `openssl` for the
+version in Ubuntu - run `lib/truffle/post_install_hook.sh`.
 
 After installing GraalVM and Ruby you will need to rebuild `openssl` for the
 version in Ubuntu - run `lib/truffle/post_install_hook.sh`. Make sure you run
 it with TruffleRuby on your `$PATH`.
 
 ## Fedora
 
-On Fedora 25 or older, the default openssl is correct, so you only need to
-install `openssl-devel`:
+On Fedora 25 or more recent, the default openssl is compatible, so you only need
+to install `openssl-devel`:
 
 ```
 sudo dnf install openssl-devel
 ```
 
-We recommend `openssl-devel` instead of `openssl`, even though we aren't using
-it for development because the latter doesn't seem to put the shared library in
-a place where we can find it.
-
 ## macOS
 
 On macOS the system version is too old. We recommend installing via

doc/user/installing-libssl.md

@@ -64,14 +64,14 @@ rebuild the Ruby executable images using the runtime from the Enterprise
 Edition. The version of the Ruby executable images you install by default uses
 the Community Edition runtime until you rebuild.
 
-To get the best performance you want to rebuild the images. Check with `ruby
---version` that it says you are running `EE` rather than `CE`.
+To get the best performance you want to rebuild the images. Check that `ruby
+--version` reports that you are running `GraalVM EE` rather than `GraalVM CE`.
 
 Rebuilding the executable images can take a few minutes and you should have
 about 8 GB of RAM available.
 
 ```
-$ graalvm/jre/lib/svm/bin/rebuild-images ruby
+$ gu rebuild-images ruby
 ```
 
 ## Using a Ruby package manager

doc/user/installing.md

@@ -30,7 +30,7 @@ TruffleRuby outside of GraalVM, such as a standard JVM, the version will be
 `'0.0'`. You can find the version number of GraalVM and TruffleRuby using the
 standard `RUBY_ENGINE_VERSION` constant.
 
-## Truffle methods
+## TruffleRuby methods
 
 TruffleRuby provides these non-standard methods that provide additional
 functionality in the `TruffleRuby` module.

doc/user/truffleruby-additions.md

@@ -420,15 +420,15 @@ enum ruby_special_consts {
     RUBY_SPECIAL_SHIFT  = 8
 };
 
-VALUE rb_tr_get_undef(void);
-VALUE rb_tr_get_true(void);
-VALUE rb_tr_get_false(void);
-VALUE rb_tr_get_nil(void);
-
-#define Qfalse rb_tr_get_false()
-#define Qtrue rb_tr_get_true()
-#define Qnil rb_tr_get_nil()
-#define Qundef rb_tr_get_undef()
+extern void* rb_tr_undef;
+extern void* rb_tr_true;
+extern void* rb_tr_false;
+extern void* rb_tr_nil;
+
+#define Qfalse ((VALUE)(&rb_tr_false))
+#define Qtrue ((VALUE)(&rb_tr_true))
+#define Qnil ((VALUE)(&rb_tr_nil))
+#define Qundef ((VALUE)(&rb_tr_undef))
 
 #define IMMEDIATE_MASK RUBY_IMMEDIATE_MASK
 #define FIXNUM_FLAG RUBY_FIXNUM_FLAG

lib/cext/include/ruby/ruby.h

@@ -1,5 +1,9 @@
 // From ./tool/generate-cext-constants.rb
 
+VALUE rb_tr_get_undef(void);
+VALUE rb_tr_get_true(void);
+VALUE rb_tr_get_false(void);
+VALUE rb_tr_get_nil(void);
 VALUE rb_tr_get_Array(void);
 VALUE rb_tr_get_Class(void);
 VALUE rb_tr_get_Comparable(void);