[GR-45621] Implement Time#deconstruct_keys

PullRequest: truffleruby/4139

Author: andrykonchin

CHANGELOG.md

@@ -38,6 +38,7 @@ Compatibility:
 * Fix `ENV#{clone,dup}` and raise `TypeError` (#3039, @andrykonchin).
 * Fix `Coverage.supported?` and raise `TypeError` if argument is not Symbol (#3039, @andrykonchin).
 * Accept options argument to `Regexp.{new,compile}` of String and warn for unknown types (#3039, @rwstauner).
+* Implement `Time#deconstruct_keys` from Ruby 3.2 (#3039, @rwstauner).
 
 Performance:
 

spec/ruby/core/time/deconstruct_keys_spec.rb

@@ -37,8 +37,9 @@
       Time.new(2022, 10, 5, 13, 30).deconstruct_keys(['year', []]).should == {}
     end
 
-    it "ignores not existing Symbol keys" do
-      Time.new(2022, 10, 5, 13, 30).deconstruct_keys([:year, :a]).should == { year: 2022 }
+    it "ignores not existing Symbol keys and processes keys after the first non-existing one" do
+      d = Time.utc(2022, 10, 5, 13, 30)
+      d.deconstruct_keys([:year, :a, :month, :b, :day]).should == { year: 2022, month: 10, day: 5 }
     end
   end
 end

spec/tags/core/time/deconstruct_keys_tags.txt

@@ -255,6 +255,42 @@ def ceil(places = 0)
     time + (ceiled - original)
   end
 
+  DEFAULT_DECONSTRUCT_KEYS = %i[year month day yday wday hour min sec subsec dst zone]
+
+  def deconstruct_keys(array_of_names)
+    unless Primitive.nil?(array_of_names) || Primitive.is_a?(array_of_names, Array)
+      raise TypeError, "wrong argument type #{Primitive.class(array_of_names)} (expected Array or nil)"
+    end
+
+    if Primitive.nil?(array_of_names)
+      array_of_names = DEFAULT_DECONSTRUCT_KEYS
+    end
+
+    ret = {}
+
+    array_of_names.each do |key|
+      value = case key
+              when :year   then year
+              when :month  then month
+              when :day    then day
+              when :yday   then yday
+              when :wday   then wday
+              when :hour   then hour
+              when :min    then min
+              when :sec    then sec
+              when :subsec then subsec
+              when :dst    then dst?
+              when :zone   then zone
+              else
+                undefined
+              end
+
+      ret[key] = value unless Primitive.undefined?(value)
+    end
+
+    ret
+  end
+
   def self._load(data)
     raise TypeError, 'marshaled time format differ' unless data.bytesize == 8
 

src/main/ruby/truffleruby/core/time.rb

@@ -27,4 +27,3 @@
 exclude :test_new, "Exception(ArgumentError) with message matches to /invalid value for Integer/."
 exclude :test_getlocal_utc_offset, "ArgumentError: \"+HH:MM\" or \"-HH:MM\" expected for utc_offset"
 exclude :test_new_from_string, "ArgumentError expected but nothing was raised."
-exclude :test_deconstruct_keys, "NoMethodError: undefined method `deconstruct_keys' for 2022-10-16 14:01:30.0005 +0900:Time"