[GR-16331] Implement {Enumerable,Enumerator::Lazy}#filter.

PullRequest: truffleruby/882

Author: nirvdrum

CHANGELOG.md

@@ -8,6 +8,7 @@ Compatibility:
 * Exceptions from `coerce` are no longer rescued, like MRI.
 * Implemented `Integer#{allbits?,anybits?,nobits?}`.
 * `Integer#{ceil,floor,truncate}` now accept a precision and `Integer#round` accepts a rounding mode.
+* Added missing `Enumerable#filter` and `Enumerator::Lazy#filter` aliases to the respective `select` method (#1610).
 
 # 20.0.0 beta 1
 

spec/tags/core/enumerable/filter_tags.txt

@@ -6,7 +6,6 @@ fails:Public methods on Complex should include to_c
 fails:Public methods on Complex should not include divide
 fails:Public methods on Complex should not include marshal_load
 fails:Public methods on Enumerable should include chain
-fails:Public methods on Enumerable should include filter
 fails:Public methods on Enumerator should include +
 fails:Public methods on File should include birthtime
 fails:Public methods on File should not include inspect

spec/tags/core/enumerator/lazy/filter_tags.txt

@@ -0,0 +1,25 @@
+chunk
+chunk_while
+collect
+collect_concat
+drop
+drop_while
+enum_for
+filter
+find_all
+flat_map
+force
+grep
+grep_v
+lazy
+map
+reject
+select
+slice_after
+slice_before
+slice_when
+take
+take_while
+to_enum
+uniq
+zip

spec/tags/truffle/methods_tags.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved. This
+# Copyright (c) 2017, 2019 Oracle and/or its affiliates. All rights reserved. This
 # code is released under a tri EPL/GPL/LGPL license. You can use it,
 # redistribute it and/or modify it under the terms of the:
 #
@@ -19,7 +19,7 @@
 modules = [
   BasicObject, Kernel, Object,
   Module, Class,
-  Enumerable, Enumerator, Range,
+  Enumerable, Enumerator, Enumerator::Lazy, Range,
   Numeric, Integer, Float,
   Rational, Complex,
   Array, Hash, String,

spec/truffle/methods/Enumerator::Lazy.txt

@@ -1928,7 +1928,7 @@ private void reverse(ArrayOperationNodes.ArrayGetNode getNode, ArrayOperationNod
 
     }
 
-    @CoreMethod(names = "select", needsBlock = true, enumeratorSize = "size")
+    @CoreMethod(names = { "select", "filter" }, needsBlock = true, enumeratorSize = "size")
     @ImportStatic(ArrayGuards.class)
     @ReportPolymorphism
     public abstract static class SelectNode extends YieldingCoreMethodNode {

spec/truffle/methods_spec.rb

@@ -501,8 +501,6 @@ def fetch(idx, default=undefined)
     self
   end
 
-  alias_method :filter, :select
-
   def first(n = undefined)
     return at(0) if undefined.equal?(n)
 

src/main/java/org/truffleruby/core/array/ArrayNodes.java

@@ -642,6 +642,7 @@ def find_all
   end
 
   alias_method :select, :find_all
+  alias_method :filter, :find_all
 
   def find_index(value=undefined)
     if undefined.equal? value

src/main/ruby/truffleruby/core/array.rb

@@ -379,6 +379,7 @@ def select
       end
     end
     alias_method :find_all, :select
+    alias_method :filter, :select
 
     def reject
       raise ArgumentError, 'Lazy#reject requires a block' unless block_given?