Skip to content

Commit 6597432

Browse files
committed
Move out primitive nodes from StringNodes into StringPrimitiveNodes
1 parent b5936a9 commit 6597432

File tree

5 files changed

+2519
-2283
lines changed

5 files changed

+2519
-2283
lines changed

src/main/java/org/truffleruby/builtins/BuiltinsClasses.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
import org.truffleruby.core.TruffleSystemNodesFactory;
2727
import org.truffleruby.core.VMPrimitiveNodesBuiltins;
2828
import org.truffleruby.core.VMPrimitiveNodesFactory;
29+
import org.truffleruby.core.string.StringPrimitiveNodesBuiltins;
30+
import org.truffleruby.core.string.StringPrimitiveNodesFactory;
2931
import org.truffleruby.core.array.ArrayIndexNodesBuiltins;
3032
import org.truffleruby.core.array.ArrayIndexNodesFactory;
3133
import org.truffleruby.core.array.ArrayNodesBuiltins;
@@ -256,6 +258,7 @@ public static void setupBuiltinsLazy(CoreMethodNodeManager coreManager) {
256258
TypeNodesBuiltins.setup(coreManager);
257259
UnboundMethodNodesBuiltins.setup(coreManager);
258260
VMPrimitiveNodesBuiltins.setup(coreManager);
261+
StringPrimitiveNodesBuiltins.setup(coreManager);
259262
WeakKeyMapNodesBuiltins.setup(coreManager);
260263
WeakMapNodesBuiltins.setup(coreManager);
261264
WeakRefNodesBuiltins.setup(coreManager);
@@ -339,6 +342,7 @@ public static void setupBuiltinsLazyPrimitives(PrimitiveManager primitiveManager
339342
TypeNodesBuiltins.setupPrimitives(primitiveManager);
340343
UnboundMethodNodesBuiltins.setupPrimitives(primitiveManager);
341344
VMPrimitiveNodesBuiltins.setupPrimitives(primitiveManager);
345+
StringPrimitiveNodesBuiltins.setupPrimitives(primitiveManager);
342346
WeakKeyMapNodesBuiltins.setupPrimitives(primitiveManager);
343347
WeakMapNodesBuiltins.setupPrimitives(primitiveManager);
344348
WeakRefNodesBuiltins.setupPrimitives(primitiveManager);
@@ -423,6 +427,7 @@ public static List<List<? extends NodeFactory<? extends RubyBaseNode>>> getCoreN
423427
TypeNodesFactory.getFactories(),
424428
UnboundMethodNodesFactory.getFactories(),
425429
VMPrimitiveNodesFactory.getFactories(),
430+
StringPrimitiveNodesFactory.getFactories(),
426431
WeakKeyMapNodesFactory.getFactories(),
427432
WeakMapNodesFactory.getFactories(),
428433
WeakRefNodesFactory.getFactories());

src/main/java/org/truffleruby/core/regexp/TruffleRegexpNodes.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
import org.truffleruby.core.string.TStringBuilder;
7070
import org.truffleruby.core.string.TStringWithEncoding;
7171
import org.truffleruby.core.string.RubyString;
72-
import org.truffleruby.core.string.StringNodes.StringAppendPrimitiveNode;
72+
import org.truffleruby.core.string.StringPrimitiveNodes.StringAppendPrimitiveNode;
7373
import org.truffleruby.core.string.StringOperations;
7474
import org.truffleruby.core.string.StringUtils;
7575
import org.truffleruby.interop.InteropNodes;

src/main/java/org/truffleruby/core/string/InterpolatedStringNode.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public final class InterpolatedStringNode extends RubyContextSourceNode {
2424

2525
@Children private final ToSNode[] children;
2626

27-
@Child private StringNodes.StringAppendPrimitiveNode appendNode;
27+
@Child private StringPrimitiveNodes.StringAppendPrimitiveNode appendNode;
2828

2929
private final RubyEncoding encoding;
3030
private final TruffleString emptyTString;
@@ -56,7 +56,7 @@ public Object execute(VirtualFrame frame) {
5656
private RubyString executeStringAppend(RubyString builder, Object string) {
5757
if (appendNode == null) {
5858
CompilerDirectives.transferToInterpreterAndInvalidate();
59-
appendNode = insert(StringNodesFactory.StringAppendPrimitiveNodeFactory.create(null));
59+
appendNode = insert(StringPrimitiveNodesFactory.StringAppendPrimitiveNodeFactory.create(null));
6060
}
6161
return appendNode.executeStringAppend(builder, string);
6262
}

0 commit comments

Comments
 (0)