Fix String#to_f and treat \v as a whitespace character

andrykonchin · andrykonchin · commit 7ce927f3aa60 · 2025-04-01T11:30:18.000+03:00
diff --git a/spec/tags/core/string/to_f_tags.txt b/spec/tags/core/string/to_f_tags.txt
@@ -1,3 +1,2 @@
 fails:String#to_f stops if the underscore is not followed or preceded by a number
-fails:String#to_f ignores leading and trailing whitespace
 fails:String#to_f raises Encoding::CompatibilityError if String is in not ASCII-compatible encoding
diff --git a/src/main/java/org/truffleruby/core/string/DoubleConverter.java b/src/main/java/org/truffleruby/core/string/DoubleConverter.java
@@ -107,7 +107,7 @@ private boolean isExponent(byte b) {
     }
 
     private boolean isWhitespace(byte b) {
-        return b == ' ' || (b <= 13 && b >= 9 && b != 11);
+        return b == ' ' || (b >= 9 && b <= 13);
     }
 
     private void addToResult(byte b) {

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,2 @@`
`1`	`1`	`fails:String#to_f stops if the underscore is not followed or preceded by a number`
`2`		`-fails:String#to_f ignores leading and trailing whitespace`
`3`	`2`	`fails:String#to_f raises Encoding::CompatibilityError if String is in not ASCII-compatible encoding`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ private boolean isExponent(byte b) {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`private boolean isWhitespace(byte b) {`
`110`		`- return b == ' ' \|\| (b <= 13 && b >= 9 && b != 11);`
	`110`	`+ return b == ' ' \|\| (b >= 9 && b <= 13);`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`private void addToResult(byte b) {`