Polish a bit method and parameter names in ImmutableStrings

@wip

Author: andrykonchin

src/main/java/org/truffleruby/RubyLanguage.java

@@ -878,12 +878,12 @@ public AllocationReporter getAllocationReporter() {
     }
 
     public ImmutableRubyString getImmutableString(TruffleString tstring, RubyEncoding encoding) {
-        return immutableStrings.getImmutableString(tstring, encoding);
+        return immutableStrings.get(tstring, encoding);
     }
 
     public ImmutableRubyString getImmutableString(InternalByteArray byteArray, boolean isImmutable,
             RubyEncoding encoding) {
-        return immutableStrings.getImmutableString(byteArray, isImmutable, encoding);
+        return immutableStrings.get(byteArray, isImmutable, encoding);
     }
 
     public long getNextObjectID() {

src/main/java/org/truffleruby/core/encoding/Encodings.java

@@ -113,7 +113,7 @@ private static RubyEncoding[] initializeRubyEncodings() {
                 if (tstring == null) {
                     throw CompilerDirectives.shouldNotReachHere("no TStringConstants for " + encoding);
                 }
-                final ImmutableRubyString name = ImmutableStrings.createStringAndCacheLater(tstring, US_ASCII);
+                final ImmutableRubyString name = ImmutableStrings.createAndCacheLater(tstring, US_ASCII);
                 rubyEncoding = new RubyEncoding(encoding, name, index);
             }
             encodings[index] = rubyEncoding;

src/main/java/org/truffleruby/core/encoding/RubyEncoding.java

@@ -79,7 +79,7 @@ public RubyEncoding(int index) {
         this.jcoding = Objects.requireNonNull(USASCIIEncoding.INSTANCE);
         this.tencoding = Objects.requireNonNull(TruffleString.Encoding.US_ASCII);
         this.name = Objects.requireNonNull(
-                ImmutableStrings.createStringAndCacheLater(TStringConstants.US_ASCII, this));
+                ImmutableStrings.createAndCacheLater(TStringConstants.US_ASCII, this));
         this.index = index;
 
         var jcoding = this.jcoding;

src/main/java/org/truffleruby/core/string/FrozenStrings.java

@@ -21,7 +21,7 @@ public final class FrozenStrings {
 
     static final List<TruffleString> TSTRINGS = new ArrayList<>();
 
-    public static final ImmutableRubyString EMPTY_US_ASCII = ImmutableStrings.createStringAndCacheLater(
+    public static final ImmutableRubyString EMPTY_US_ASCII = ImmutableStrings.createAndCacheLater(
             TStringConstants.EMPTY_US_ASCII,
             Encodings.US_ASCII);
 
@@ -50,7 +50,7 @@ private static ImmutableRubyString createFrozenStaticString(String string, RubyE
         // defined?(...) returns frozen strings with a binary encoding
         var tstring = TStringUtils.fromJavaString(string, encoding);
         TSTRINGS.add(tstring);
-        return ImmutableStrings.createStringAndCacheLater(tstring, encoding);
+        return ImmutableStrings.createAndCacheLater(tstring, encoding);
     }
 
 }

src/main/java/org/truffleruby/core/string/ImmutableRubyString.java

@@ -43,7 +43,7 @@
 
 import java.util.Objects;
 
-/** All ImmutableRubyString are interned and must be created through {@link ImmutableStrings#getImmutableString}. */
+/** All ImmutableRubyString are interned and must be created through {@link ImmutableStrings#get}. */
 @ExportLibrary(InteropLibrary.class)
 public final class ImmutableRubyString extends ImmutableRubyObjectCopyable
         implements TruffleObject, DetailedInspectingSupport {

src/main/java/org/truffleruby/core/string/ImmutableStrings.java

@@ -31,23 +31,23 @@ public final class ImmutableStrings {
     public ImmutableStrings(TStringCache tStringCache) {
         this.tstringCache = tStringCache;
         for (ImmutableRubyString name : STRINGS_TO_CACHE) {
-            addImmutableStringToCache(name);
+            addToCache(name);
         }
     }
 
     @TruffleBoundary
-    public ImmutableRubyString getImmutableString(TruffleString tstring, RubyEncoding encoding) {
-        return getImmutableString(
+    public ImmutableRubyString get(TruffleString tstring, RubyEncoding encoding) {
+        return get(
                 tstring.getInternalByteArrayUncached(encoding.tencoding),
                 TStringUtils.hasImmutableInternalByteArray(tstring),
                 encoding);
     }
 
     @TruffleBoundary
-    public ImmutableRubyString getImmutableString(InternalByteArray byteArray, boolean isImmutable,
+    public ImmutableRubyString get(InternalByteArray byteArray, boolean isLookupKeyImmutable,
             RubyEncoding encoding) {
         // Ensure all ImmutableRubyString have a TruffleString from the TStringCache
-        var cachedTString = tstringCache.getTString(byteArray, isImmutable, encoding);
+        var cachedTString = tstringCache.getTString(byteArray, isLookupKeyImmutable, encoding);
         var tstringWithEncoding = new TStringWithEncoding(cachedTString, encoding);
 
         final ImmutableRubyString string = values.get(tstringWithEncoding);
@@ -59,7 +59,7 @@ public ImmutableRubyString getImmutableString(InternalByteArray byteArray, boole
     }
 
     @TruffleBoundary
-    public ImmutableRubyString getImmutableString(byte[] bytes, RubyEncoding encoding) {
+    public ImmutableRubyString get(byte[] bytes, RubyEncoding encoding) {
         // Ensure all ImmutableRubyString have a TruffleString from the TStringCache
         var cachedTString = tstringCache.getTString(bytes, encoding);
         var tstringWithEncoding = new TStringWithEncoding(cachedTString, encoding);
@@ -72,15 +72,15 @@ public ImmutableRubyString getImmutableString(byte[] bytes, RubyEncoding encodin
         }
     }
 
-    public static ImmutableRubyString createStringAndCacheLater(TruffleString name,
+    public static ImmutableRubyString createAndCacheLater(TruffleString name,
             RubyEncoding encoding) {
         final ImmutableRubyString string = new ImmutableRubyString(name, encoding);
         assert !STRINGS_TO_CACHE.contains(string);
         STRINGS_TO_CACHE.add(string);
         return string;
     }
 
-    private void addImmutableStringToCache(ImmutableRubyString string) {
+    private void addToCache(ImmutableRubyString string) {
         var encoding = string.getEncodingUncached();
         var cachedTString = tstringCache.getTString(string.tstring, encoding);
         assert cachedTString == string.tstring;
@@ -93,7 +93,7 @@ private void addImmutableStringToCache(ImmutableRubyString string) {
     }
 
     @TruffleBoundary
-    public Collection<ImmutableRubyString> allImmutableStrings() {
+    public Collection<ImmutableRubyString> all() {
         return values.values();
     }
 

src/main/java/org/truffleruby/language/objects/ObjectGraph.java

@@ -115,7 +115,7 @@ public void run(RubyThread rubyThread, Node currentNode) {
     public static void visitContextRoots(RubyContext context, Set<Object> roots) {
         final RubyLanguage language = context.getLanguageSlow();
         roots.addAll(language.symbolTable.allSymbols());
-        roots.addAll(language.immutableStrings.allImmutableStrings());
+        roots.addAll(language.immutableStrings.all());
 
         // We do not want to expose the global object
         roots.addAll(context.getCoreLibrary().globalVariables.objectGraphValues());

src/main/java/org/truffleruby/parser/YARPTranslator.java

@@ -3253,7 +3253,7 @@ public RubyNode visitStringNode(Nodes.StringNode node) {
             final TruffleString cachedTString = language.tstringCache.getTString(bytes, encoding);
             rubyNode = new StringLiteralNode(cachedTString, encoding);
         } else {
-            ImmutableRubyString immutableString = language.immutableStrings.getImmutableString(bytes, encoding);
+            ImmutableRubyString immutableString = language.immutableStrings.get(bytes, encoding);
             rubyNode = new FrozenStringLiteralNode(immutableString, FrozenStrings.EXPRESSION);
         }