Skip to content

[GR-53433] Workaround build name clash and copy build instead of symlinking #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[GR-53433] Workaround build name clash and copy build instead of symlinking #3533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions tool/jt.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,13 +2533,8 @@ def sforceimports

dest = "#{TRUFFLERUBY_DIR}/mxbuild/#{name}"
FileUtils.rm_rf dest
if @ruby_name != @mx_env
# if `--name NAME` is passed, we want to copy so we don't end up with two symlinks
# to the same directory for the same --env but different names
FileUtils.cp_r(build_dir, dest)
else
File.symlink(build_dir, dest)
end
# NOTE: revert the changes and create a symlink if possible when [GR-53433] is resolved
FileUtils.cp_r(build_dir, dest)

# Symlink builds into version manager
rbenv_root = ENV['RBENV_ROOT']
Expand Down
Loading