Do not approve this until the previous PR is approved. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a critical flaw in the existing code for the training pipeline.
…ain folder as it is not a utility involved in batched or one off embeddings. Updated package.json to remove unused dependencies. Fiddled with some console log art
…to their own CSV file for analysis and comparison. Notably there are some unanswered questions here regarding the storage of large text over time. Theoretically this could be a problem. Additionally, some workflows may EXPLICITLY not want to track inputs, but this feature is being implemented as a hardcoded "always do this". I will see about implementing a bash command to enable or disable this feature in the next commit.
…fy a static file that contains the property. I tried to achieve this with a config.js file, but as soon as the context window closes, the toggle goes back to whatever value it had before. As a reuslt, I tried creating a config JSON so that config settings are modifyable using the command line interface. This backfired as import type assertions for JSON files are not working in my environment, and I dont want to risk this being broken for other people in their deployments. As a result, the fucntion is always enabled, but the config.js file will read env variables for text logging instead.
…are pre-suppored.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a config setting that is toggleable, we need to modify a static file that contains the property. I tried to achieve this with a config.js file, but as soon as the context window closes, the toggle goes back to whatever value it had before.
As a result, I tried creating a config JSON so that config settings are modifiable using the command line interface. This backfired as import type assertions for JSON files are not working in my environment, and I don't want to risk this being broken for other people in their deployments.
As a result, the function is always enabled, but the config.js file will read env variables for text logging instead.