Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify debts + group balances #197

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Simplify debts + group balances #197

wants to merge 29 commits into from

Conversation

krokosik
Copy link

@krokosik krokosik commented Feb 17, 2025 •
edited
Loading

Closes #158
Closes #58

  • added personal balances on group page underneath the total balance
  • added a balance list page for group
  • added a simplify debts toggle in group options and a database field
  • implemented a debt simplification algorithm based on this article
  • created some unit tests and added Jest
  • moved the expense list into a component shared with both the firend and group page
  • added new shadcn aliases for compatibility with newer CLI versions
  • moved some devDependencies from prod dependencies in package.json
  • fixed some missing keys console errors due to incorrect usage of React fragments
  • fixed a dev console error on missing Web Push key throwing an undefined query result error

krokosik and others added 20 commits February 18, 2025 00:11
@krokosik
Add a simplify debts field to groups
209b669
@krokosik
Do not return undefined in trpc query to silence console error
cbd67de
@krokosik
Add a switch component and add now required shadcn aliases
1a7e9b2
@krokosik
Add a simplify debts toggle to UI
3f154e8
@krokosik
Fix list key errors on group page
17227f4
@krokosik
Show per group member balances
13cf771
@krokosik
Process group balances with useMemo
07128bd
@krokosik
Add dinic algorithm package
b4bfe7e
@krokosik
Remove the client side simplify stub, as it should be done server side
b849d7d
@krokosik
Move expense list to a shared component
2a74981
@krokosik
Add accordion component
34bf1f9
@krokosik
Balance list with totals
ad1b15f
@krokosik
Use number type for group/friend id in ExpenseList
1596409
@krokosik
Complete BalanceList
f549b37
@krokosik
Add Jest and move dev dependencies to proper dep group
be5f3b1
@krokosik
Create a basic test suite for simplifyDebts based on the examples in …
511b102 
…articles
@krokosik
Implement the debt simplification algorithm and adjust test cases
42b49ce
@krokosik
Use the simplify algorithm in API
14e345e
@krokosik
Handle multiple currencies and use node indices for Dinic
a8d0fe0
@krokosik
Do not list to many personal balances
1c11bba
@krokosik krokosik marked this pull request as draft February 18, 2025 09:08
@krokosik krokosik marked this pull request as ready for review February 18, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Group Balance Page and Cash Flow Minimization Option to simplify Debts
1 participant
@krokosik