Enhancement of SA rationales and implementation details #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SecurityCRob
commented
Jan 24, 2025
SecurityCRob
commented
<title>
<title> Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
puerco
reviewed
Jan 24, 2025
evankanderson
approved these changes
Jan 25, 2025
baseline/OSPS-SA.yaml
Outdated
Comment on lines
69
to
72
| Providing project maintainers an understand of how | ||
| the software can be misused or broken allows them | ||
| to paln mitigations to close off the potential of | ||
| those threats from occuring. |
There was a problem hiding this comment.
Suggested change
| Providing project maintainers an understand of how | |
| the software can be misused or broken allows them | |
| to paln mitigations to close off the potential of | |
| those threats from occuring. | |
| A threat model helps project maintainers understand | |
| how the software can be misused or broken. Using | |
| this understanding, maintainers can mitigate those | |
| threats during design, implementation, or testing. |
The initial sentence contains passive voice ("providing") and weasel words ("allows them", "potential of") in a complex sentence. I think this version is more straightforward and easier to understand.
|
I'm good once puerco & Evan's suggestions are implemented. |
Co-authored-by: Puerco <puerco@users.noreply.github.com> Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Co-authored-by: Puerco <puerco@users.noreply.github.com> Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
funnelfiasco
approved these changes
Jan 27, 2025
Signed-off-by: Eddie Knight <knight@linux.com>
eddie-knight
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
@SecurityCRob please confirm you're happy with the changes I just committed to your branch
Co-authored-by: Ben Cotton <ben@kusari.dev> Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.