-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lexicon.yaml with control mappings #179
Conversation
add control mapping references Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall, just a couple of questions before I ✅
synonyms: | ||
- SSDF | ||
- NIST Secure Software Development Framework | ||
- NIST SP 800-218 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add "SP 800-218" as a synonym?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to chat more about how we're taking advantage of synonyms— right not they are not being rendered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #182 for that conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fixing meow
YAML error, too:
|
Co-authored-by: Eddie Knight <knight@linux.com> Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
tweaked ssdf Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
now with 100% MOAR SBOM! Signed-off-by: CRob <69357996+SecurityCRob@users.noreply.github.com>
Signed-off-by: Ben Cotton <ben@kusari.dev>
I pushed commit ea5808b which fixes this. (The problem was leading spaces before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two minor comments (we can fix them in another PR)
Co-authored-by: Puerco <puerco@users.noreply.github.com> Signed-off-by: Eddie Knight <knight@linux.com>
add control mapping references