Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '--version' option #111

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

aaroncohen73
Copy link
Contributor

fixes issue #83

Changes in this PR.

  • Added -v/--version option

Testing this PR.

  1. Run nosetests
  2. Run climesync/climesync.py -v and see that version and license information is printed out

@osuosl/devs

@pop
Copy link

pop commented Oct 7, 2016

Feedback

  • --version doesn't seem to work for me. 😞
  • We should add just a version sub-command. This is becoming more standard.
  • -v works fine, but I'd suggest that it be an abbreviated version of the outplocalhostut. Just the version and not the license, for instance.

This looks good so far, just some improvements.

Copy link
Contributor

@MorganEPatch MorganEPatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I'd recommend storing the version as some sort of constant near the top of the source code or similar.

  2. I'd add a version command inside climesync that prints the same information.

  3. -v works for me, but --version doesn't. It just prints usage information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants