Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ubuntu upgrade #46

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: ubuntu upgrade #46

merged 1 commit into from
Oct 22, 2024

Conversation

Faraz32123
Copy link
Contributor

@Faraz32123 Faraz32123 commented Sep 3, 2024 •
edited
Loading

  • Update Credentials Image to use Ubuntu 24.04 as base OS.
  • Add mime-support alternatives that are media-types mailcap.
  • Update python-openssl to python3-openssl.
  • add changelog entry.
  • close Ubuntu 24.04 Upgrade #45

@Faraz32123 Faraz32123 marked this pull request as draft September 3, 2024 14:28
@Faraz32123 Faraz32123 self-assigned this Sep 3, 2024
@Faraz32123
Copy link
Contributor Author

Update: Credential's Dockerfile Build was successful, but getting below warnings. Will look into it further.

 3 warnings found (use --debug to expand):

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/pg2gu8pixxe580iujriqm3744
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CREDENTIALS_REPOSITORY") (line 38)
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CREDENTIALS_VERSION") (line 39)
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CREDENTIALS_CFG") (line 130)

@Faraz32123 Faraz32123 marked this pull request as ready for review October 10, 2024 13:11
@Faraz32123
Copy link
Contributor Author

Update: Credential's Dockerfile Build was successful, but getting below warnings. Will look into it further.

 3 warnings found (use --debug to expand):

View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/pg2gu8pixxe580iujriqm3744
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CREDENTIALS_REPOSITORY") (line 38)
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "CREDENTIALS_VERSION") (line 39)
 - SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CREDENTIALS_CFG") (line 130)

these warnings are occurring due to word credentials in variable name, have added a comment in dockerfile regarding this.

regisb
regisb reviewed Oct 10, 2024
View reviewed changes
tutorcredentials/templates/credentials/build/credentials/Dockerfile Outdated

# From then on, run as unprivileged "app" user
ARG APP_USER_ID=1000
ARG APP_USER_ID=1001
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost certainly not a good idea. See this comment for more information: https://github.com/overhangio/tutor/pull/1117/files#r1795117242

feat: ubuntu upgrade to 24.04
b7b5c8a 
- Update Credentials Image to use Ubuntu `24.04` as base OS.
- Change `APP_USER_ID` to 1001 as UID 1000 is now shipped by default.
- Add `mime-support` alternatives that are `media-types mailcap`.
- Update `python-openssl` to `python3-openssl`.
- add changelog entry.
@Faraz32123 Faraz32123 changed the title [WIP] feat: ubuntu upgrade feat: ubuntu upgrade Oct 17, 2024
@Faraz32123 Faraz32123 requested a review from regisb October 17, 2024 10:44
@Faraz32123 Faraz32123 merged commit c72ffd8 into nightly Oct 22, 2024
@DawoudSheraz DawoudSheraz mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawoudSheraz DawoudSheraz DawoudSheraz approved these changes

@regisb regisb Awaiting requested review from regisb

Assignees

@Faraz32123 Faraz32123

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faraz32123 @regisb @DawoudSheraz