code review: first round of comments

overhangio · Oct 29, 2024 · 0874b2f · 0874b2f
1 parent 5332024
commit 0874b2f
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/tutor/templates/apps/openedx/config/cms.env.yml b/tutor/templates/apps/openedx/config/cms.env.yml
@@ -9,7 +9,6 @@ FEATURES:
   {{ patch("cms-env-features")|indent(2) }}
   CERTIFICATES_HTML_VIEW: true
   PREVIEW_LMS_BASE: "{{ PREVIEW_LMS_HOST }}"
-  ENABLE_COURSEWARE_INDEX: true
   ENABLE_CSMH_EXTENDED: false
   ENABLE_LEARNER_RECORDS: false
   ENABLE_LIBRARY_INDEX: true

diff --git a/tutor/templates/apps/openedx/config/lms.env.yml b/tutor/templates/apps/openedx/config/lms.env.yml
@@ -9,10 +9,7 @@ FEATURES:
   {{ patch("lms-env-features")|indent(2) }}
   CERTIFICATES_HTML_VIEW: true
   PREVIEW_LMS_BASE: "{{ PREVIEW_LMS_HOST }}"
-  ENABLE_COURSE_DISCOVERY: true
-  ENABLE_COURSEWARE_SEARCH: true
   ENABLE_CSMH_EXTENDED: false
-  ENABLE_DASHBOARD_SEARCH:  true
   ENABLE_COMBINED_LOGIN_REGISTRATION: true
   ENABLE_GRADE_DOWNLOADS: true
   ENABLE_LEARNER_RECORDS: false

diff --git a/tutor/templates/apps/openedx/settings/partials/common_lms.py b/tutor/templates/apps/openedx/settings/partials/common_lms.py
@@ -40,6 +40,7 @@
 # Enable search features
 FEATURES["ENABLE_COURSE_DISCOVERY"] = True
 FEATURES["ENABLE_COURSEWARE_SEARCH"] = True
+FEATURES["ENABLE_DASHBOARD_SEARCH"] = True
 
 # Create folders if necessary
 for folder in [DATA_DIR, LOG_DIR, MEDIA_ROOT, STATIC_ROOT, ORA2_FILEUPLOAD_ROOT]:

diff --git a/tutor/templates/dev/docker-compose.yml b/tutor/templates/dev/docker-compose.yml
@@ -32,13 +32,15 @@ services:
     ports:
         - "8001:8000"
 
+  {% if RUN_MEILISEARCH -%}
   meilisearch:
     ports:
       - "127.0.0.1:7700:7700"
     networks:
       default:
         aliases:
           - "{{ MEILISEARCH_PUBLIC_URL.split('://')[1] }}"
+  {%- endif %}
 
   # Additional service for watching theme changes
   watchthemes:

diff --git a/tutor/templates/k8s/volumes.yml b/tutor/templates/k8s/volumes.yml
@@ -28,7 +28,7 @@ spec:
     - ReadWriteOnce
   resources:
     requests:
-      storage: 2Gi
+      storage: 5Gi
 {% endif %}
 {% if RUN_MONGODB %}
 ---