feat: avoid slow reindex of studio content during init #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
reviewed
Dec 9, 2024
| # index (resulting in broken features until it is complete). If either of those | ||
| # are necessary, it will print instructions on what command to run to do so. | ||
| ./manage.py cms reindex_studio --experimental --init | ||
| # Create the courseware content index | ||
| ./manage.py cms reindex_course --active |
There was a problem hiding this comment.
What about course content? will it also not replace existing indices?
There was a problem hiding this comment.
I'm not sure about the reindex_course command - I haven't been making any changes to the learner-facing courseware search. So it should work the same way it always has, but presumably using Meilisearch instead of Elasticsearch. I think this is something we can improve in future releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that openedx/edx-platform#35981 has merged to Sumac, solving openedx/modular-learning#235 , we can update the command that Tutor uses to populate the initial Studio search index.
What this means:
initduring instance setup will be nearly-instant.initthat they need to runreindex_studiomanually. The index will be created automatically duringinit, but it will be incomplete (existing content absent, but new content will show up in it). Theinitduring instance setup will be nearly-instant, and the reindex command will take a few minutes when run manually.initthat they need to runreindex_studiomanually. The index will be created automatically duringinit, but it will be incomplete (existing content absent, but new content will show up in it). Theinitduring instance setup will be nearly-instant, and the reindex command could take up to several days when run manually. It can be interrupted and resumed as needed.Compare this to the situation before this change:
initduring instance setup will be nearly-instant.initduring instance setup will take a few minutes.initprocess tries to runreindex_studio, and it takes several days and likely never completes before the task is terminated for one reason or another.FYI @regisb @DanielVZ96 @ChrisChV @ormsbee