Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid slow reindex of studio content during init #1174

Merged
merged 1 commit into from
Dec 9, 2024
Merged

feat: avoid slow reindex of studio content during init #1174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tutor/templates/jobs/init/cms.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ fi
# Copy-paste of units in Studio (highly requested new feature, but defaults to off in Quince)
(./manage.py cms waffle_flag --list | grep contentstore.enable_copy_paste_units) || ./manage.py lms waffle_flag --create contentstore.enable_copy_paste_units --everyone

# Re-index studio and courseware content
# Note that this might be slow for large courses until this issue is resolved:
# https://github.com/openedx/modular-learning/issues/235
# But this is a necessary step to make sure the indexes are created and properly
# configured.
./manage.py cms reindex_studio --experimental
# Create the index for studio and courseware content. Because we specify --init,
# this will not populate the index (potentially slow) nor replace any existing
# index (resulting in broken features until it is complete). If either of those
# are necessary, it will print instructions on what command to run to do so.
./manage.py cms reindex_studio --experimental --init
# Create the courseware content index
./manage.py cms reindex_course --active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about course content? will it also not replace existing indices?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the reindex_course command - I haven't been making any changes to the learner-facing courseware search. So it should work the same way it always has, but presumably using Meilisearch instead of Elasticsearch. I think this is something we can improve in future releases.