-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cli for listing available patches #798
Conversation
Looking good so far. Just let me know when you need a review. |
c76b686
to
d70f99a
Compare
c6e23fa
to
f762ff7
Compare
f762ff7
to
1565d09
Compare
This is ready for review @regisb @kdmccormick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like your implementation, which is very lean and does not change the rest of the codebase. Also, the command output looks great and quite useful. Finally, I appreciate the fact that you took the time to write extensive unit tests.
Can you just address the comments and add a changelog entry? https://docs.tutor.overhang.io/tutor.html#contributing-to-tutor
Nice work. The output looks great! I have no suggestions beyond what @regisb has already said. |
1565d09
to
e9c5c66
Compare
e9c5c66
to
62958cc
Compare
This PR is ready @regisb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just great!
Description
This PR adds
tutor config patches list
command with its functionality.How to test
Run
Expected result:
If you had patches in a plugin patches (ex: You have defined caddyfile-mfe2 inside a caddyfile-global in a plugin):
For more context about this PR: openedx-unsupported/wg-developer-experience#50