Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .webp and .otf file extensions to list of binary file extensions #985

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

ravikhetani
Copy link
Contributor

Short term solution to address issue raised in #975, which was causing tutor to throw exceptions when enabling theming plugins, which included file extensions not specified by BIN_FILE_EXTENSIONS in env.py

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please rebase your changes on top of master and run make format to properly format your code.

@ravikhetani ravikhetani requested a review from regisb January 22, 2024 10:20
@ravikhetani
Copy link
Contributor Author

@regisb Done

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@regisb regisb merged commit b832f51 into overhangio:master Jan 22, 2024
1 check passed
kdmccormick pushed a commit to kdmccormick/tutor that referenced this pull request Feb 8, 2024
This partially addresses overhangio#985.

---------

Co-authored-by: Ravi Khetani <r.khetani@institute.global>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants