add alternative header ending signature

orangecms · orangecms · commit 3ed94884ea9d · 2024-11-06T00:36:07.000+01:00
This is found in ASRock firmware images, e.g. A520M-HVS A52MIX_2.73. Also seen in coreboot 3rd_party/blobs/mainboard/, and used in Fiano: https://github.com/linuxboot/fiano/blob/d844cd98141518f41b3e4012bcf419984074a2b4/pkg/amd/apcb/internal.go#L16 Signed-off-by: Daniel Maslowski <info@orangecms.org>
diff --git a/src/apcb.rs b/src/apcb.rs
@@ -1268,8 +1268,12 @@ impl<'a> Apcb<'a> {
                     "V3_HEADER_EXT::data_offset",
                 ));
             }
+            // NOTE: The AMD docs for Turin, Genoa, Milan and Rome say `BCPA`,
+            // i.e., `APCB` backwards. Some vendors are using `BCBA` instead,
+            // e.g., ASRock and coreboot (`3rdparty/blobs/mainboard/`).
             if !options.check_signature_ending
                 || value.signature_ending == *b"BCPA"
+                || value.signature_ending == *b"BCBA"
             {
             } else {
                 return Err(Error::FileSystem(

Original file line number	Diff line number	Diff line change
`@@ -1268,8 +1268,12 @@ impl<'a> Apcb<'a> {`
`1268`	`1268`	`"V3_HEADER_EXT::data_offset",`
`1269`	`1269`	`));`
`1270`	`1270`	`}`
	`1271`	+ // NOTE: The AMD docs for Turin, Genoa, Milan and Rome say `BCPA`,
	`1272`	+ // i.e., `APCB` backwards. Some vendors are using `BCBA` instead,
	`1273`	+ // e.g., ASRock and coreboot (`3rdparty/blobs/mainboard/`).
`1271`	`1274`	`if !options.check_signature_ending`
`1272`	`1275`	`\|\| value.signature_ending == *b"BCPA"`
	`1276`	`+ \|\| value.signature_ending == *b"BCBA"`
`1273`	`1277`	`{`
`1274`	`1278`	`} else {`
`1275`	`1279`	`return Err(Error::FileSystem(`