[nexus] the support bundle task should execute diag commands concurrently #7461
Conversation
Created using spr 1.3.6-beta.1
| while let Some(result) = diag_cmds.next().await { | ||
| result?; | ||
| } |
There was a problem hiding this comment.
Just to confirm, this will exit only if we fail to write the output of the command, not if the commands themselves fail, right? Just want to make sure that one failing command on a sled would not short-circuit everything else.
There was a problem hiding this comment.
Right, it's only going to fail if the tokio::write call fails on the support bundle file itself.
But thinking about this, should we instead log that we failed to write to file rather then potentially not getting through the entire array?
There was a problem hiding this comment.
Agree it's better to get partial results than nothing at all.
There was a problem hiding this comment.
Fixed in 6b02fb3
| while let Some(result) = diag_cmds.next().await { | ||
| result?; | ||
| } |
There was a problem hiding this comment.
Agree it's better to get partial results than nothing at all.
Created using spr 1.3.6-beta.1
|
The test failure seems related to oxidecomputer/buildomat#62 so I am going to re-run it. |
This PR adds some of the
sled-diagnosticscrates commands that were not yet being collected. Additionally we now have an array of commands that will be ran concurrently (currently limited to 10 at a time) that we can add to as more support commands become available.