Add an SPD proxy mux #294
Merged
Add an SPD proxy mux #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron-Hartwig
commented
Feb 20, 2025
| -- Wait out tbuf to ensure STOP/START spacing | ||
| when WAIT_TBUF => | ||
| if sm_count_done then | ||
| v := SM_REG_RESET; |
There was a problem hiding this comment.
For context as to why I moved WAIT_TBUF to be after the STOP states: since we indicate controller business by "if I'm not in IDLE", this keeps the controller from advertising it is ready for another transaction until it can actually execute that transaction. Behavior today is that it will accept the new transaction but then wait for TBUF anyway.
Aaron-Hartwig
commented
Feb 20, 2025
Aaron-Hartwig
force-pushed
the
aaron/spd-mux
branch
from
d23b10d to
195fc25
Compare
Aaron-Hartwig
commented
Feb 20, 2025
nathanaelhuffman
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
spd_proxy_topblock whose intention is to house an I2C controller which will attempt to utilize the DIMM bus while a CPU is not using it. When the CPU begins using the bus the internal controller will wrap up what it is doing as quickly as possible and we will attempt to gracefully hand the bus over the CPU in a way that doesn't cause problems.