Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merging num/str validations that are equal #517

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

rkusa
Copy link
Contributor

@rkusa rkusa commented Mar 3, 2024

While trying to use progenitor with the DHL Express API, I received the following unimplemented panic: this is fairly fussy and I don't want to do it.

I tracked the panic down to merge_so_number in this repo.

The validation rules it tried to merge where the same, which is why I were able to fix the panic by adding another case that handles if both a and b are defined but simply the same.

@ahl
Copy link
Collaborator

ahl commented Mar 4, 2024

Thanks for this step forward; if you decide this isn't too fussy to do, a contribution to merge the constraints would be much appreciated.

@ahl ahl merged commit c5ebe0a into oxidecomputer:main Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants