Fix merging num/str validations that are equal #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use progenitor with the DHL Express API, I received the following unimplemented panic:
this is fairly fussy and I don't want to do it
.I tracked the panic down to
merge_so_number
in this repo.The validation rules it tried to merge where the same, which is why I were able to fix the panic by adding another case that handles if both
a
andb
are defined but simply the same.