Pkotest #179
Draft
Pkotest #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
…ache accessor requests
This fixes a bug where gcCache tries to close a nil channel in the cacheWaitInFlight map.
```
2025-04-28T13:02:17Z INFO ObjectBoundAccessManager.TrackingCache stopping informers {"gvks": [{"Group":"[apiextensions.k8s.io](http://apiextensions.k8s.io)","Version":"v1","Kind":"CustomResourceDefinition"}]}
panic: close of nil channel
goroutine 455 [running]:
pkg.package-operator.run/boxcutter/managedcache.(*trackingCache).RemoveOtherInformers.func1({0x27ff2f0, 0xc001103da0})
pkg.package-operator.run/boxcutter@v0.1.0/managedcache/trackingcache.go:391 +0x4d9
pkg.package-operator.run/boxcutter/managedcache.(*trackingCache).Start(0xc00084ab40, {0x27ff328, 0xc00086cb90})
pkg.package-operator.run/boxcutter@v0.1.0/managedcache/trackingcache.go:142 +0x2dd
pkg.package-operator.run/boxcutter/managedcache.(*objectBoundAccessManagerImpl[...]).handleAccessorRequest.func1(0xc0000584d0)
pkg.package-operator.run/boxcutter@v0.1.0/managedcache/objectboundaccess.go:309 +0xaf
created by pkg.package-operator.run/boxcutter/managedcache.(*objectBoundAccessManagerImpl[...]).handleAccessorRequest in goroutine 217
pkg.package-operator.run/boxcutter@v0.1.0/managedcache/objectboundaccess.go:307 +0xb6c
```
Co-Authored-By: Nico Schieder <nschieder@redhat.com>
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
…etInformer instead of cache.GetInformerForKind to avoid a scheme lookup error Error: object /a-foo kind:Foo: getting k8s.erdii.net/v1, Kind=Foo: no kind \"Foo\" is registered for version \"k8s.erdii.net/v1\" in scheme \"pkg/runtime/scheme.go:100\" we're using controller-runtime's informerCache [1] and that implementation's GetInformerForKind tries to instanciate a new typed struct for the given gvk [2]. This does not work because the scheme does not contain the type. [1] https://github.com/kubernetes-sigs/controller-runtime/blob/6ad5c1dd4418489606d19dfb87bf38905b440561/pkg/cache/informer_cache.go#L67 [2] https://github.com/kubernetes-sigs/controller-runtime/blob/6ad5c1dd4418489606d19dfb87bf38905b440561/pkg/cache/informer_cache.go#L155
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 46.29% 46.06% -0.24%
==========================================
Files 29 30 +1
Lines 2985 3000 +15
==========================================
Hits 1382 1382
- Misses 1492 1507 +15
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.