Skip to content

Handle qualifiers with a string value #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steven-esser opened this issue Dec 29, 2018 · 5 comments
Closed

Handle qualifiers with a string value #4

steven-esser opened this issue Dec 29, 2018 · 5 comments

Comments

@steven-esser
Copy link
Collaborator

Currently we throw an exception when creating a packageURL with qualifiers that are strings.

The python version currently handles this, so the JS version should as well.

@Omkaragrawal
Copy link

Omkaragrawal commented Mar 27, 2019

Hey,
Does creating Purl with qualifiers that are string means something like:

pkg:maven/org.apache.xmlgraphics/batik-anim@1.9.1?repository_url=repo.spring.io/\"release\"
or something similar?
Sorry to ask if this is a silly question.

@jkowalleck
Copy link
Member

Qualifiers are expected to be a dictionary of strings. see https://github.com/package-url/packageurl-js/blob/9998e463ba5e4ad0be96b52e12497d089bdb0b97/src/package-url.d.ts#L68C3-L70

the described feature would bean, that you could set the property to 'foo=1&bar=baz' and it would be internally converted to a dictionary: {foo:1,bar:'baz'}

@jdalton
Copy link
Collaborator

jdalton commented Aug 14, 2024

Fixed by #73, specifically 978280e.

@jdalton
Copy link
Collaborator

jdalton commented Aug 16, 2024

Closed by #73

@jdalton jdalton closed this as completed Aug 16, 2024
@jdalton
Copy link
Collaborator

jdalton commented Aug 18, 2024

v2.0.0 has been published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants