fixed code

Author: michaeldisaro

src/main/java/it/gov/pagopa/paymentupdater/service/PaymentServiceImpl.java

@@ -16,6 +16,7 @@
 import org.springframework.transaction.annotation.Transactional;
 import org.springframework.web.client.HttpClientErrorException;
 import org.springframework.web.client.HttpServerErrorException;
+import org.springframework.web.client.HttpStatusCodeException;
 import org.springframework.web.client.RestTemplate;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
@@ -27,10 +28,8 @@
 import it.gov.pagopa.paymentupdater.model.Payment;
 import it.gov.pagopa.paymentupdater.producer.PaymentProducer;
 import it.gov.pagopa.paymentupdater.repository.PaymentRepository;
-import it.gov.pagopa.paymentupdater.restclient.proxy.ApiClient;
 import it.gov.pagopa.paymentupdater.restclient.proxy.api.DefaultApi;
 import it.gov.pagopa.paymentupdater.restclient.proxy.model.PaymentRequestsGetResponse;
-import it.gov.pagopa.paymentupdater.util.Constants;
 import it.gov.pagopa.paymentupdater.util.PaymentUtil;
 import lombok.extern.slf4j.Slf4j;
 
@@ -80,7 +79,7 @@ public ProxyResponse checkPayment(Payment payment)
       LocalDate dueDate = PaymentUtil.getLocalDateFromString(resp.getDueDate());
       proxyResp.setDueDate(dueDate);
       return proxyResp;
-    } catch (HttpClientErrorException errorException) {
+    } catch (HttpStatusCodeException errorException) {
       // manage 4XX errors
       ProxyPaymentResponse res = mapper.readValue(errorException.getResponseBodyAsString(),
         ProxyPaymentResponse.class);
@@ -115,9 +114,6 @@ public ProxyResponse checkPayment(Payment payment)
       } else {
         throw errorException;
       }
-    } catch (HttpServerErrorException errorException) {
-      // manage 5XX errors
-      throw errorException;
     }
   }
 

src/test/java/it/gov/pagopa/paymentupdater/AbstractMock.java

@@ -149,8 +149,7 @@ public void mockGetPaymentInfoError() throws JsonProcessingException {
 
 	protected Payment selectReminderMockObject(String type, String id, String contentType, String fiscalCode,
 			int numReminder, String rptId, String paymentDataNoticeNumber, String paymentDataFiscalCode) {
-		Payment returnReminder1 = null;
-		returnReminder1 = new Payment();
+		Payment returnReminder1 = new Payment();
 		returnReminder1.setId(id);
 		returnReminder1.setContent_type(MessageContentType.valueOf(contentType));
 		returnReminder1.setFiscalCode(fiscalCode);