Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkMessage will always call proxy #50

Closed
wants to merge 1 commit into from
Closed

fix: checkMessage will always call proxy #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/main/java/it/gov/pagopa/paymentupdater/controller/PaymentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,10 @@ public ResponseEntity<ApiPaymentMessage> getMessagePayment(@PathVariable String
if (payment == null)
return new ResponseEntity<>(HttpStatus.NOT_FOUND);

if (!payment.isPaidFlag()) {
// FIX: sometimes we miss a payment event so if this payment is not paid we try to call paymentService
if (paymentServiceImpl != null) {
ProxyResponse proxyResponse = paymentServiceImpl.checkPayment(payment);
if (proxyResponse != null) {
payment.setPaidFlag(proxyResponse.isPaid());
paymentService.save(payment);
}
}
ProxyResponse proxyResponse = paymentServiceImpl.checkPayment(payment);
if (proxyResponse != null) {
payment.setPaidFlag(proxyResponse.isPaid());
paymentService.save(payment);
}

ApiPaymentMessage apiPaymentMessage = ApiPaymentMessage.builder()
Expand Down
1 change: 0 additions & 1 deletion src/main/java/it/gov/pagopa/paymentupdater/service/PaymentServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ public void save(Payment reminder) {
}

@Override

public ProxyResponse checkPayment(Payment payment)
throws JsonProcessingException, InterruptedException, ExecutionException {
LocalDate paymentDueDate = payment.getDueDate() != null ? payment.getDueDate().toLocalDate() : null;
Expand Down