Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PagoPA-2427 migration service type adjustment 1️⃣ ㏈ #272

Merged
merged 8 commits into from
Jan 20, 2025
Merged

feat: PagoPA-2427 migration service type adjustment 1️⃣ ㏈ #272

merged 8 commits into from
Jan 20, 2025

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • created script to adjust values ​​in the serviceType field of ACA and WISP type debt positions

Motivation and Context

  • correctly value the previous ACA and WISP type debt positions

How Has This Been Tested?

  • manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli marked this pull request as ready for review November 28, 2024 11:50
@alessio-acitelli alessio-acitelli requested a review from a team as a code owner November 28, 2024 11:50
@alessio-acitelli alessio-acitelli mentioned this pull request Nov 28, 2024
Merged
6 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cap-ang
cap-ang reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a doubt: does the execution of this transaction block other transactions? What kind of lock does it acquire?

it is important to understand this and test the migration duration, downtime should be avoided

@pasqualespica pasqualespica self-requested a review December 2, 2024 07:19
pasqualespica
pasqualespica approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test it into UAT env , according to @cap-ang comment too

@alessio-acitelli
Copy link
Collaborator Author

alessio-acitelli commented Dec 2, 2024 •
edited
Loading

Just a doubt: does the execution of this transaction block other transactions? What kind of lock does it acquire?

it is important to understand this and understand the duration of the migration, downtime should be avoided

Yes, DML operation of type UPDATE locks the affected rows during the transaction.
The database locks the affected rows to prevent concurrent changes from other transactions.
This means that no other transaction can read or write the same rows until the lock is released (COMMIT or ROLLBACK).

To limit the problem, the transactional block could be removed, but the risk is that, in the event of errors, an inconsistent situation could be created.

Execution detail in UAT via dbeaver:

Execute time (ms) 13913
Fetch time (ms) 0
Total time (ms) 13913
Start time 2024-12-02 09:42:18.628
Finish time 2024-12-02 09:42:32.547

@pasqualespica pasqualespica changed the title feat: [PagoPA-2427] - service type adjustment feat: [PagoPA-2427] - migration service type adjustment Dec 6, 2024
@pasqualespica pasqualespica added documentation Improvements or additions to documentation dev labels Dec 6, 2024
@pasqualespica pasqualespica added uat and removed uat labels Dec 6, 2024
@alessio-acitelli alessio-acitelli mentioned this pull request Dec 19, 2024
Merged
5 tasks
@cap-ang
Copy link
Contributor

cap-ang commented Jan 9, 2025

Changes are included in this PR

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pasqualespica pasqualespica changed the title feat: [PagoPA-2427] - migration service type adjustment feat: PagoPA-2427 migration service type adjustment Jan 14, 2025
@pasqualespica pasqualespica changed the title feat: PagoPA-2427 migration service type adjustment feat: PagoPA-2427 migration service type adjustment 1️⃣ Jan 14, 2025
@pasqualespica pasqualespica changed the title feat: PagoPA-2427 migration service type adjustment 1️⃣ feat: PagoPA-2427 migration service type adjustment 1️⃣ ㏈ Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

@pasqualespica pasqualespica merged commit 006ceaa into main Jan 20, 2025
34 of 41 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-2427-serviceType-adjustment branch January 20, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cap-ang cap-ang cap-ang left review comments

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
dev documentation Improvements or additions to documentation prod size/small uat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-acitelli @cap-ang @pasqualespica @pagopa-github-bot