Skip to content

Commit 01aba7e

Browse files
committed
feat: remove InstitutionType from Product and increase version 0.2.0
1 parent 8d185ef commit 01aba7e

File tree

7 files changed

+15
-19
lines changed

7 files changed

+15
-19
lines changed

libs/onboarding-sdk-azure-storage/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>it.pagopa.selfcare</groupId>
88
<artifactId>onboarding-sdk-pom</artifactId>
9-
<version>0.1.21</version>
9+
<version>0.2.0</version>
1010
<relativePath>../onboarding-sdk-pom</relativePath>
1111
</parent>
1212

libs/onboarding-sdk-common/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>it.pagopa.selfcare</groupId>
66
<artifactId>onboarding-sdk-pom</artifactId>
7-
<version>0.1.21</version>
7+
<version>0.2.0</version>
88
<relativePath>../onboarding-sdk-pom</relativePath>
99
</parent>
1010
<artifactId>onboarding-sdk-common</artifactId>

libs/onboarding-sdk-crypto/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>it.pagopa.selfcare</groupId>
66
<artifactId>onboarding-sdk-pom</artifactId>
7-
<version>0.1.21</version>
7+
<version>0.2.0</version>
88
<relativePath>../onboarding-sdk-pom</relativePath>
99
</parent>
1010
<artifactId>onboarding-sdk-crypto</artifactId>

libs/onboarding-sdk-pom/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<artifactId>onboarding-sdk-pom</artifactId>
77
<packaging>pom</packaging>
88
<name>onboarding-sdk-pom</name>
9-
<version>0.1.21</version>
9+
<version>0.2.0</version>
1010

1111
<properties>
1212
<maven.compiler.source>17</maven.compiler.source>

libs/onboarding-sdk-product/pom.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
<parent>
55
<groupId>it.pagopa.selfcare</groupId>
66
<artifactId>onboarding-sdk-pom</artifactId>
7-
<version>0.1.21</version>
7+
<version>0.2.0</version>
88
<relativePath>../onboarding-sdk-pom</relativePath>
99
</parent>
1010
<artifactId>onboarding-sdk-product</artifactId>
1111
<name>onboarding-sdk-product</name>
12-
<version>0.1.21</version>
12+
<version>0.2.0</version>
1313

1414
<properties>
1515
<jackson.version>2.15.2</jackson.version>
16-
<onboarding-sdk.version>0.1.21</onboarding-sdk.version>
16+
<onboarding-sdk.version>0.2.0</onboarding-sdk.version>
1717
</properties>
1818

1919
<dependencies>

libs/onboarding-sdk-product/src/main/java/it/pagopa/selfcare/product/entity/Product.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package it.pagopa.selfcare.product.entity;
22

3-
import it.pagopa.selfcare.onboarding.common.InstitutionType;
43
import it.pagopa.selfcare.onboarding.common.PartyRole;
54

65
import java.time.Instant;
@@ -27,7 +26,7 @@ public class Product {
2726
private Instant contractTemplateUpdatedAt;
2827
private String contractTemplatePath;
2928
private String contractTemplateVersion;
30-
private Map<InstitutionType, ContractStorage> institutionContractMappings;
29+
private Map<String, ContractStorage> institutionContractMappings;
3130
private boolean enabled = true;
3231
private boolean delegable;
3332
private boolean invoiceable;
@@ -177,11 +176,11 @@ public void setContractTemplateVersion(String contractTemplateVersion) {
177176
this.contractTemplateVersion = contractTemplateVersion;
178177
}
179178

180-
public Map<InstitutionType, ContractStorage> getInstitutionContractMappings() {
179+
public Map<String, ContractStorage> getInstitutionContractMappings() {
181180
return institutionContractMappings;
182181
}
183182

184-
public void setInstitutionContractMappings(Map<InstitutionType, ContractStorage> institutionContractMappings) {
183+
public void setInstitutionContractMappings(Map<String, ContractStorage> institutionContractMappings) {
185184
this.institutionContractMappings = institutionContractMappings;
186185
}
187186

libs/onboarding-sdk-product/src/main/java/it/pagopa/selfcare/product/service/ProductServiceDefault.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@
1010
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
1111
import it.pagopa.selfcare.onboarding.common.InstitutionType;
1212
import it.pagopa.selfcare.onboarding.common.PartyRole;
13-
import it.pagopa.selfcare.product.entity.Product;
14-
import it.pagopa.selfcare.product.entity.ProductRole;
15-
import it.pagopa.selfcare.product.entity.ProductRoleInfo;
16-
import it.pagopa.selfcare.product.entity.ProductStatus;
13+
import it.pagopa.selfcare.product.entity.*;
1714
import it.pagopa.selfcare.product.exception.InvalidRoleMappingException;
1815
import it.pagopa.selfcare.product.exception.ProductNotFoundException;
1916

@@ -148,9 +145,10 @@ private Product getProduct(String productId, boolean filterValid) {
148145
*/
149146
@Override
150147
public void fillContractTemplatePathAndVersion(Product product, InstitutionType institutionType) {
151-
if (institutionType != null && product.getInstitutionContractMappings() != null && product.getInstitutionContractMappings().containsKey(institutionType)) {
152-
product.setContractTemplatePath(product.getInstitutionContractMappings().get(institutionType).getContractTemplatePath());
153-
product.setContractTemplateVersion(product.getInstitutionContractMappings().get(institutionType).getContractTemplateVersion());
148+
if (Objects.nonNull(institutionType) && Objects.nonNull(product.getInstitutionContractMappings())
149+
&& product.getInstitutionContractMappings().containsKey(institutionType.name())) {
150+
product.setContractTemplatePath(product.getInstitutionContractMappings().get(institutionType.name()).getContractTemplatePath());
151+
product.setContractTemplateVersion(product.getInstitutionContractMappings().get(institutionType.name()).getContractTemplateVersion());
154152
}
155153
}
156154

@@ -204,5 +202,4 @@ private static boolean statusIsNotValid(ProductStatus status) {
204202
return List.of(ProductStatus.INACTIVE, ProductStatus.PHASE_OUT).contains(status);
205203
}
206204

207-
208205
}

0 commit comments

Comments
 (0)