From c33a6bdd97c4343263a9ba5c92433741a9b401ae Mon Sep 17 00:00:00 2001
From: Manuel Rafeli <manuel.rafeli@pagopa.it>
Date: Wed, 25 Sep 2024 11:34:23 +0200
Subject: [PATCH] refactor: standardize using onboarding-sdk-version on entire
 project (#503)

---
 apps/onboarding-cdc/pom.xml         |  7 ------
 apps/onboarding-functions/pom.xml   | 36 ++++++++++++-----------------
 apps/onboarding-ms/pom.xml          | 28 +++++++++-------------
 apps/pom.xml                        |  8 +++++++
 libs/onboarding-sdk-product/pom.xml |  5 ++--
 5 files changed, 36 insertions(+), 48 deletions(-)

diff --git a/apps/onboarding-cdc/pom.xml b/apps/onboarding-cdc/pom.xml
index 6e3c14a8d..275ce2c4b 100644
--- a/apps/onboarding-cdc/pom.xml
+++ b/apps/onboarding-cdc/pom.xml
@@ -24,7 +24,6 @@
         <quarkus.platform.version>3.5.2</quarkus.platform.version>
         <skipITs>true</skipITs>
         <surefire-plugin.version>3.1.2</surefire-plugin.version>
-        <onboarding-sdk.version>0.2.1</onboarding-sdk.version>
         <quarkus-openapi-generator.version>2.4.1</quarkus-openapi-generator.version>
     </properties>
     <dependencyManagement>
@@ -115,12 +114,6 @@
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-smallrye-health</artifactId>
         </dependency>
-        <dependency>
-            <groupId>it.pagopa.selfcare</groupId>
-            <artifactId>onboarding-sdk-common</artifactId>
-            <version>${onboarding-sdk.version}</version>
-            <scope>compile</scope>
-        </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-rest-client-reactive-jackson</artifactId>
diff --git a/apps/onboarding-functions/pom.xml b/apps/onboarding-functions/pom.xml
index 39a1aa8b8..aeb73f5ea 100644
--- a/apps/onboarding-functions/pom.xml
+++ b/apps/onboarding-functions/pom.xml
@@ -21,7 +21,6 @@
     <quarkus.platform.version>3.5.1</quarkus.platform.version>
     <skipITs>true</skipITs>
     <surefire-plugin.version>3.1.2</surefire-plugin.version>
-    <onboarding-sdk.version>0.2.1</onboarding-sdk.version>
     <mapstruct.version>1.5.5.Final</mapstruct.version>
   </properties>
 
@@ -66,26 +65,6 @@
       <groupId>io.quarkus</groupId>
       <artifactId>quarkus-mailer</artifactId>
     </dependency>
-    <dependency>
-      <groupId>it.pagopa.selfcare</groupId>
-      <artifactId>onboarding-sdk-azure-storage</artifactId>
-      <version>${onboarding-sdk.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>it.pagopa.selfcare</groupId>
-      <artifactId>onboarding-sdk-product</artifactId>
-      <version>${onboarding-sdk.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>it.pagopa.selfcare</groupId>
-      <artifactId>onboarding-sdk-common</artifactId>
-      <version>${onboarding-sdk.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>it.pagopa.selfcare</groupId>
-      <artifactId>onboarding-sdk-crypto</artifactId>
-      <version>${onboarding-sdk.version}</version>
-    </dependency>
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-text</artifactId>
@@ -211,6 +190,21 @@
         <artifactId>applicationinsights-web</artifactId>
         <version>2.6.4</version>
     </dependency>
+    <dependency>
+      <groupId>it.pagopa.selfcare</groupId>
+      <artifactId>onboarding-sdk-crypto</artifactId>
+      <version>0.2.1</version>
+    </dependency>
+    <dependency>
+      <groupId>it.pagopa.selfcare</groupId>
+      <artifactId>onboarding-sdk-azure-storage</artifactId>
+      <version>0.2.1</version>
+    </dependency>
+    <dependency>
+      <groupId>it.pagopa.selfcare</groupId>
+      <artifactId>onboarding-sdk-product</artifactId>
+      <version>0.2.1</version>
+    </dependency>
   </dependencies>
   <build>
     <plugins>
diff --git a/apps/onboarding-ms/pom.xml b/apps/onboarding-ms/pom.xml
index d90421317..1ecd481f1 100644
--- a/apps/onboarding-ms/pom.xml
+++ b/apps/onboarding-ms/pom.xml
@@ -23,7 +23,6 @@
         <quarkus.platform.version>3.11.2</quarkus.platform.version>
         <skipITs>true</skipITs>
         <surefire-plugin.version>3.1.2</surefire-plugin.version>
-        <onboarding-sdk.version>0.2.1</onboarding-sdk.version>
         <quarkus-openapi-generator.version>2.4.1</quarkus-openapi-generator.version>
     </properties>
     <dependencyManagement>
@@ -139,22 +138,6 @@
             <artifactId>quarkus-test-security-jwt</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>it.pagopa.selfcare</groupId>
-            <artifactId>onboarding-sdk-common</artifactId>
-            <version>${onboarding-sdk.version}</version>
-        </dependency>
-
-        <dependency>
-            <groupId>it.pagopa.selfcare</groupId>
-            <artifactId>onboarding-sdk-azure-storage</artifactId>
-            <version>${onboarding-sdk.version}</version>
-        </dependency>
-        <dependency>
-            <groupId>it.pagopa.selfcare</groupId>
-            <artifactId>onboarding-sdk-product</artifactId>
-            <version>${onboarding-sdk.version}</version>
-        </dependency>
 
 
         <!-- https://mvnrepository.com/artifact/eu.europa.ec.joinup.sd-dss/dss-test -->
@@ -251,6 +234,17 @@
             <scope>compile</scope>
         </dependency>
 
+        <dependency>
+            <groupId>it.pagopa.selfcare</groupId>
+            <artifactId>onboarding-sdk-azure-storage</artifactId>
+            <version>0.2.1</version>
+        </dependency>
+        <dependency>
+            <groupId>it.pagopa.selfcare</groupId>
+            <artifactId>onboarding-sdk-product</artifactId>
+            <version>0.2.1</version>
+        </dependency>
+
     </dependencies>
     <build>
         <plugins>
diff --git a/apps/pom.xml b/apps/pom.xml
index 6763a933d..db6db6bdc 100644
--- a/apps/pom.xml
+++ b/apps/pom.xml
@@ -12,6 +12,14 @@
     <artifactId>onboarding-apps</artifactId>
     <packaging>pom</packaging>
 
+    <dependencies>
+        <dependency>
+            <groupId>it.pagopa.selfcare</groupId>
+            <artifactId>onboarding-sdk-common</artifactId>
+            <version>0.2.1</version>
+        </dependency>
+    </dependencies>
+
     <profiles>
         <profile>
             <id>onboarding-ms</id>
diff --git a/libs/onboarding-sdk-product/pom.xml b/libs/onboarding-sdk-product/pom.xml
index bd3cd38a8..c69eb2706 100644
--- a/libs/onboarding-sdk-product/pom.xml
+++ b/libs/onboarding-sdk-product/pom.xml
@@ -13,7 +13,6 @@
 
     <properties>
         <jackson.version>2.15.2</jackson.version>
-        <onboarding-sdk.version>0.2.1</onboarding-sdk.version>
     </properties>
 
     <dependencies>
@@ -26,13 +25,13 @@
         <dependency>
             <groupId>it.pagopa.selfcare</groupId>
             <artifactId>onboarding-sdk-azure-storage</artifactId>
-            <version>${onboarding-sdk.version}</version>
+            <version>${project.version}</version>
         </dependency>
 
         <dependency>
             <groupId>it.pagopa.selfcare</groupId>
             <artifactId>onboarding-sdk-common</artifactId>
-            <version>${onboarding-sdk.version}</version>
+            <version>${project.version}</version>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>