Update test

Author: pierpaolo.didato@emeal.nttdata.com

apps/onboarding-functions/src/test/java/it/pagopa/selfcare/onboarding/functions/OnboardingFunctionsTest.java

@@ -14,11 +14,9 @@
 import it.pagopa.selfcare.onboarding.HttpResponseMessageMock;
 import it.pagopa.selfcare.onboarding.common.OnboardingStatus;
 import it.pagopa.selfcare.onboarding.common.WorkflowType;
-import it.pagopa.selfcare.onboarding.entity.AggregateInstitution;
 import it.pagopa.selfcare.onboarding.entity.Institution;
 import it.pagopa.selfcare.onboarding.entity.Onboarding;
 import it.pagopa.selfcare.onboarding.exception.ResourceNotFoundException;
-import it.pagopa.selfcare.onboarding.mapper.OnboardingMapper;
 import it.pagopa.selfcare.onboarding.service.CompletionService;
 import it.pagopa.selfcare.onboarding.service.NotificationEventService;
 import it.pagopa.selfcare.onboarding.service.OnboardingService;
@@ -60,9 +58,6 @@ public class OnboardingFunctionsTest {
     @InjectMock
     NotificationEventService notificationEventService;
 
-    @Inject
-    OnboardingMapper onboardingMapper;
-
     final String onboardinString = "{\"onboardingId\":\"onboardingId\"}";
 
     final String onboardingWorkflowString = "{\"type\":\"INSTITUTION\",\"onboarding\":{\"id\":\"id\",\"productId\":null,\"testEnvProductIds\":null,\"workflowType\":null,\"institution\":null,\"users\":null,\"aggregates\":null,\"pricingPlan\":null,\"billing\":null,\"signContract\":null,\"expiringDate\":null,\"status\":null,\"userRequestUid\":null,\"workflowInstanceId\":null,\"createdAt\":null,\"updatedAt\":null,\"activatedAt\":null,\"deletedAt\":null,\"reasonForReject\":null,\"isAggregator\":null}}";
@@ -117,7 +112,7 @@ public void startAndWaitOrchestration_failedOrchestration() throws Exception {
     void onboardingsOrchestrator_throwExceptionIfOnboardingNotPresent() {
         final String onboardingId = "onboardingId";
         TaskOrchestrationContext orchestrationContext = mock(TaskOrchestrationContext.class);
-        
+
         when(orchestrationContext.getInput(String.class)).thenReturn(onboardingId);
         when(service.getOnboarding(onboardingId)).thenReturn(Optional.empty());
         assertThrows(ResourceNotFoundException.class, () -> function.onboardingsOrchestrator(orchestrationContext, executionContext));
@@ -171,44 +166,6 @@ void onboardingOrchestratorContractRegistrationAggregator(){
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
     }
 
-    @Test
-    void onboardingOrchestratorContractRegistrationAggregator_Pending(){
-        Onboarding onboarding = new Onboarding();
-        onboarding.setId("onboardingId");
-        onboarding.setStatus(OnboardingStatus.PENDING);
-        AggregateInstitution aggregate1 = new AggregateInstitution();
-        aggregate1.setTaxCode("code1");
-        AggregateInstitution aggregate2 = new AggregateInstitution();
-        aggregate1.setTaxCode("code2");
-        AggregateInstitution aggregate3 = new AggregateInstitution();
-        aggregate1.setTaxCode("code3");
-        onboarding.setAggregates(List.of(aggregate1, aggregate2, aggregate3));
-        Institution institution = new Institution();
-        institution.setId("id");
-        onboarding.setInstitution(institution);
-        onboarding.setWorkflowType(WorkflowType.CONTRACT_REGISTRATION_AGGREGATOR);
-
-        TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        function.onboardingsOrchestrator(orchestrationContext, executionContext);
-
-        ArgumentCaptor<String> captorActivity = ArgumentCaptor.forClass(String.class);
-        Mockito.verify(orchestrationContext, times(5))
-                .callActivity(captorActivity.capture(), any(), any(),any());
-        assertEquals(CREATE_INSTITUTION_ACTIVITY, captorActivity.getAllValues().get(0));
-        assertEquals(CREATE_ONBOARDING_ACTIVITY, captorActivity.getAllValues().get(1));
-        assertEquals(CREATE_USERS_ACTIVITY, captorActivity.getAllValues().get(2));
-        assertEquals(STORE_ONBOARDING_ACTIVATEDAT, captorActivity.getAllValues().get(3));
-        assertEquals(SEND_MAIL_COMPLETION_ACTIVITY, captorActivity.getAllValues().get(4));
-
-        Mockito.verify(orchestrationContext, times(3))
-                .callSubOrchestrator(eq(ONBOARDINGS_AGGREGATE_ORCHESTRATOR), any(), any());
-
-        Mockito.verify(service, times(1))
-                .updateOnboardingStatus(onboarding.getId(), OnboardingStatus.COMPLETED);
-
-        function.onboardingsOrchestrator(orchestrationContext, executionContext);
-    }
-
     @Test
     void onboardingsOrchestratorNewAdminRequest() {
         Onboarding onboarding = new Onboarding();
@@ -239,7 +196,7 @@ void onboardingsOrchestratorForApprove() {
         onboarding.setWorkflowType(WorkflowType.FOR_APPROVE);
 
         TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        
+
 
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
 
@@ -260,7 +217,7 @@ void onboardingsOrchestratorForApproveWhenToBeValidated() {
         onboarding.setWorkflowType(WorkflowType.FOR_APPROVE);
 
         TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        
+
 
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
 
@@ -284,7 +241,7 @@ void onboardingsOrchestratorConfirmation() {
         onboarding.setInstitution(new Institution());
 
         TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        
+
 
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
 
@@ -489,7 +446,7 @@ void onboardingsOrchestratorRegistrationRequestApprove() {
         onboarding.setWorkflowType(WorkflowType.FOR_APPROVE_PT);
 
         TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        
+
 
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
 
@@ -535,7 +492,6 @@ TaskOrchestrationContext mockTaskOrchestrationContext(Onboarding onboarding) {
 
         Task task = mock(Task.class);
         when(orchestrationContext.callActivity(any(),any(),any(),any())).thenReturn(task);
-        when(orchestrationContext.callSubOrchestrator(any(),any())).thenReturn(task);
         when(task.await()).thenReturn("example");
         when(orchestrationContext.allOf(anyList())).thenReturn(task);
         return orchestrationContext;
@@ -554,7 +510,7 @@ void buildContract() {
 
     @Test
     void saveToken() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(service).saveTokenWithContract(any());
 
@@ -566,7 +522,7 @@ void saveToken() {
 
     @Test
     void sendMailRegistrationWithContract() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(service).sendMailRegistrationForContract(any());
 
@@ -579,7 +535,7 @@ void sendMailRegistrationWithContract() {
 
     @Test
     void sendMailRegistration() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(service).sendMailRegistration(any());
 
@@ -591,7 +547,7 @@ void sendMailRegistration() {
 
     @Test
     void sendMailRegistrationApprove() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(service).sendMailRegistrationApprove(any());
 
@@ -603,7 +559,7 @@ void sendMailRegistrationApprove() {
 
     @Test
     void sendMailOnboardingApprove() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(service).sendMailOnboardingApprove(any());
 
@@ -615,7 +571,7 @@ void sendMailOnboardingApprove() {
 
     @Test
     void sendMailRegistrationWithContractWhenApprove() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(service).sendMailRegistrationForContractWhenApprove(any());
 
@@ -635,7 +591,7 @@ void onboardingCompletionOrchestrator() {
         onboarding.setInstitution(new Institution());
 
         TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        
+
 
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
 
@@ -665,7 +621,7 @@ void onboardingRejectedOrchestrator() {
         onboarding.setInstitution(new Institution());
 
         TaskOrchestrationContext orchestrationContext = mockTaskOrchestrationContext(onboarding);
-        
+
 
         function.onboardingsOrchestrator(orchestrationContext, executionContext);
 
@@ -692,7 +648,7 @@ void createInstitutionAndPersistInstitutionId() {
 
     @Test
     void sendCompletedEmail() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(completionService).sendCompletedEmail(any());
 
@@ -704,7 +660,7 @@ void sendCompletedEmail() {
 
     @Test
     void sendMailRejection() {
-        
+
         when(executionContext.getLogger()).thenReturn(Logger.getGlobal());
         doNothing().when(completionService).sendMailRejection(any());
 
@@ -766,4 +722,4 @@ void createDelegationForAggregation() {
         verify(completionService, times(1))
                 .createDelegation(any());
     }
-}
+}