[SELC-5034] feature: added logic to discriminate event type in cdc module #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gianmarcoplutino
approved these changes
Jun 5, 2024
andrea-putzu
approved these changes
Jun 5, 2024
manuraf
reviewed
Jun 6, 2024
| }; | ||
| } | ||
|
|
||
| private boolean isOverUpdateThreshold(LocalDateTime updatedAt, LocalDateTime activatedAt) { |
There was a problem hiding this comment.
it might be better to add some comments about this function...what means "isOverUpdateThreshold" ?
| @@ -15,6 +15,7 @@ onboarding-cdc.storage.connection-string=${STORAGE_CONNECTION_STRING:UseDevelopm | |||
| onboarding-cdc.retry.min-backoff=${ONBOARDING-CDC-RETRY-MIN-BACKOFF:1} | |||
| onboarding-cdc.retry.max-backoff=${ONBOARDING-CDC-RETRY-MAX-BACKOFF:2} | |||
| onboarding-cdc.retry=${ONBOARDING-CDC-RETRY:3} | |||
| onboarding-cdc.minutes-threshold-for-update-notification=${ONBOARDING-CDC-MINUTES-THRESHOLD-FOR-UPDATE-NOTIFICATION:5} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Added logic to discriminate event type in cdc module before invoking function to send notifications
Motivation and Context
With this feature we have the ability to understand if the result of a change in an onboarding document we need to send an event on ADD or UPDATE on queues
How Has This Been Tested?
local env
Screenshots (if appropriate):
Types of changes
Checklist: