Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 5148] feat: added new AggregateInstitution Object #330

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

List of Changes

Added :

  • AggregateInstitution (ms)
  • AggregateInstitutionRequest
  • AggregateInstitution (function)
  • updated function openapi to ms and cdc

Motivation and Context

This change was necessary because during the testing and integration phase with the BFF we realized that some attributes were required in the normal flow and in the case of Aggregator these attributes are not needed

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner June 21, 2024 08:11
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Jun 21, 2024
@gianmarcoplutino gianmarcoplutino merged commit 3347acd into main Jun 21, 2024
9 of 10 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-5148 branch June 21, 2024 14:06
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions onboarding-ms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants