Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5214] feat: Added previousManagerId as attribute of Onboarding in order to detect email template #378

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

pierpaolodidato89
Copy link
Collaborator

List of Changes

  • Added previousManagerId as attribute of Onboarding in order to detect email template
  • Added previous manager name and previous manager surname into registration email in case of workflow USERS

Motivation and Context

In order to display name and surname of previous manager in case of addition administration flow, a new attribute has been added into Onboarding class. This attribute stores the previous manager identifier and it's used to compare current manager id with old one

How Has This Been Tested?

I have deployed the feature branch in dev and tested the entire process of onboarding for workflowType USERS

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Jul 3, 2024
Copy link

sonarqubecloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@pierpaolodidato89 pierpaolodidato89 merged commit 00fe361 into main Jul 4, 2024
20 of 21 checks passed
@pierpaolodidato89 pierpaolodidato89 deleted the feature/SELC-5214 branch July 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions onboarding-ms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants