Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5284] fix: Added step to persist activatedAt for onboarding with workflowType USERS #396

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[SELC-5284] fix: Added step to persist activatedAt for onboarding with workflowType USERS #396

merged 1 commit into from
Jul 18, 2024

Conversation

pierpaolodidato89
Copy link
Collaborator

List of Changes

Added step to persist activatedAt for onboarding with workflowType USERS

Motivation and Context

For workflowType USERS, the field activatedAt was not filled during onboarding's completion

How Has This Been Tested?

I have deployed the feature branch in DEV and completed the entire process of onboarding for a new institution

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the functions Changes are related to functions label Jul 16, 2024
@pierpaolodidato89 pierpaolodidato89 marked this pull request as ready for review July 16, 2024 13:01
@pierpaolodidato89 pierpaolodidato89 requested a review from a team as a code owner July 16, 2024 13:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

andrea-putzu
andrea-putzu approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@andrea-putzu andrea-putzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pierpaolodidato89 pierpaolodidato89 merged commit cc18f89 into main Jul 18, 2024
11 checks passed
@pierpaolodidato89 pierpaolodidato89 deleted the bugfix/SELC-5284 branch July 18, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-putzu andrea-putzu andrea-putzu approved these changes

Assignees
No one assigned
Labels
functions Changes are related to functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierpaolodidato89 @andrea-putzu