Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase Go version #453

Merged
merged 4 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: '1.22.2'
go-version: '1.23.5'
cache: false
- name: Go lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.55.2
version: v1.63.4
args: --verbose
# Optional: if set to true then the all caching functionality will be complete disabled,
# takes precedence over all other caching options.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
buildx:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # stick with older LTS release for continued debian support
steps:
-
name: Checkout
Expand Down
3 changes: 2 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
run:
go: '1.22.2'
go: '1.23.5'
issues-exit-code: 1
timeout: 10m
modules-download-mode: readonly
Expand Down Expand Up @@ -38,3 +38,4 @@ issues:
# gosec
- G101 # Potential hardcoded credentials
- G114 # Use of net/http serve function that has no support for setting timeouts
- G115 # We use this everywhere (I guess at least if it overflows, it will for everyone...)
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
###########################
#### Base image ####
###########################
FROM golang:1.22-bullseye AS base
FROM golang:1.23-bullseye AS base
WORKDIR /app

###########################
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
BRANCH := $(shell git rev-parse --abbrev-ref HEAD)
COMMIT := $(shell git log -1 --format='%H')
BUILD_DIR ?= $(CURDIR)/build
GOLANGCILINT_VERSION := 1.51.2
GOLANGCILINT_VERSION := 1.63.4

.PHONY: install-linter install-abigen build build-linux

Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ mkdir ~/.pigeon

### To build pigeon using latest

> [!IMPORTANT]
> Always make sure you're building against the latest released version of Go.

```shell
git clone https://github.com/palomachain/pigeon.git
cd pigeon
Expand Down
1 change: 0 additions & 1 deletion chain/evm/deploy_contract.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ func (c *Client) wrapArbitrumDeployment(
c.config.GasAdjustment,
c.config.TxType,
)

if err != nil {
logger.WithError(err).Error("failed to deploy contract to arbitrum")
return
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/palomachain/pigeon

go 1.22.2
go 1.23.5

require (
cosmossdk.io/errors v1.0.1
Expand Down
4 changes: 2 additions & 2 deletions internal/mev/blxr/relay.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ func (c *Client) Relay(ctx context.Context, chainID *big.Int, tx *types.Transact

if res.StatusCode() != http.StatusOK {
if len(r.Error.Message) > 0 {
return nilHash, fmt.Errorf(r.Error.Message)
return nilHash, fmt.Errorf("%s", r.Error.Message)
}

return nilHash, fmt.Errorf(string(res.Body()))
return nilHash, fmt.Errorf("%s", string(res.Body()))
}

if len(r.Result.Txhash) < 1 {
Expand Down
1 change: 0 additions & 1 deletion util/ion/tx.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ func (cc *Client) SendMsgs(ctx context.Context, msgs []sdk.Msg, memo string, opt
}
return nil
}()

if err != nil {
return nil, err
}
Expand Down
Loading