Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST (string dtype): avoid hardcoded object dtype for columns in datetime_frame fixture #60192

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Nov 5, 2024

Avoiding the explicit object dtype in construction of the DataFrame fixture allows to remove a few xfails

xref #54792

@jorisvandenbossche jorisvandenbossche added the Strings String extension data type and string data label Nov 5, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 5, 2024
@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review November 5, 2024 14:07
@jorisvandenbossche jorisvandenbossche merged commit 34387bd into pandas-dev:main Nov 5, 2024
50 of 51 checks passed
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-tests-fixtu-frame branch November 5, 2024 16:23
Copy link

lumberbot-app bot commented Nov 5, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 34387bddffacb158a60a249b08411a8a1fe44455
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60192: TST (string dtype): avoid hardcoded object dtype for columns in datetime_frame fixture'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60192-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60192 on branch 2.3.x (TST (string dtype): avoid hardcoded object dtype for columns in datetime_frame fixture)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60198

mroeschke pushed a commit that referenced this pull request Nov 5, 2024
… columns in datetime_frame fixture (#60192) (#60198)

TST (string dtype): avoid hardcoded object dtype for columns in datetime_frame fixture (#60192)

(cherry picked from commit 34387bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant