Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST (string dtype): avoid explicit object dtype Index in fixture data #60217

Conversation

jorisvandenbossche
Copy link
Member

(opening this to see which tests are failing on a full CI test run)

xref #54792

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Nov 6, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 6, 2024
@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review November 6, 2024 18:53
@mroeschke mroeschke merged commit 4b04a2f into pandas-dev:main Nov 6, 2024
51 checks passed
Copy link

lumberbot-app bot commented Nov 6, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4b04a2f0043ad04b5546750a8947dfeef68cdb75
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60217: TST (string dtype): avoid explicit object dtype Index in fixture data'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60217-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60217 on branch 2.3.x (TST (string dtype): avoid explicit object dtype Index in fixture data)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the string-dtype-tests-fixture-no-object-index branch November 6, 2024 20:22
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Nov 7, 2024
…pandas-dev#60217)

* TST (string dtype): avoid explicit object dtype Index in fixture data

* test updates

(cherry picked from commit 4b04a2f)
@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60225

jorisvandenbossche added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants