Skip to content

Commit

Permalink
Protocols: Revert ‘Delete where file does not exist is OK’ rucio#7386
Browse files Browse the repository at this point in the history
This reverts commit 996493d. The
motivation behind that change is unclear. However, it is damaging in
three ways:

 1. Breaks deletions for commercial clouds using pre-signed URLs.
 2. Reduces the deletion performance at far-away RSEs.
 3. Renders the operation timeout ineffective.
  • Loading branch information
dchristidis authored and bari12 committed Feb 10, 2025
1 parent 68c7e1f commit d3c1c0c
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions lib/rucio/rse/protocols/gfal.py
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,9 @@ def __gfal2_rm(self, paths):

try:
for path in paths:
if self.__gfal2_exist(path) == 0:
ret = ctx.unlink(str(path))
if ret:
return ret
else:
raise exception.SourceNotFound
ret = ctx.unlink(str(path))
if ret:
return ret
return ret
except gfal2.GError as error: # pylint: disable=no-member
if error.code == errno.ENOENT or 'No such file' in str(error):
Expand Down

0 comments on commit d3c1c0c

Please sign in to comment.