Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-mode layout issues #33

Open
ThomasWaldmann opened this issue Nov 4, 2013 · 3 comments
Open

line-mode layout issues #33

ThomasWaldmann opened this issue Nov 4, 2013 · 3 comments

Comments

@ThomasWaldmann
Copy link

There are some layout issues in line mode:

If all buttons take more width than available, it wraps to another line, but usually the lines do not have enough vertical distance. I worked around that by specifying more height.

Another issue is that it in general tends to look rather ugly as the spacing is not the same for every button, e.g. the visual distance between switch and service button but also the visual distance between service button and the switch of the element right of that (this is maybe due to some buttons getting wider when activated).

And even if one tries to work around that by setting some specific common width (as in the screenshot), it still looks strange, because there is more white space on the right of the whole share block than on the left.

ssp-line

@panzi
Copy link
Owner

panzi commented Nov 4, 2013

Yeah, if you want to improve the CSS, I accept patches/pull requests. ;)

@ThomasWaldmann
Copy link
Author

That's me and CSS: http://i.imgur.com/Q3cUg29.gif

@panzi
Copy link
Owner

panzi commented Nov 5, 2013

Yeah, that seems accurate.

Well, if anyone sends me a patch about that I'll merge it. But it's not a big enough itch for me. Especially because it very much depends on how you use it. You might want to optimize for different things depending on how you embed it in your page (different widths/heights; making buttons the same width makes only sense if you have >1 line, otherwise there will be awkward white spaces).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants