Skip to content

[stable2503] Backport #8373 #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Conversation

paritytech-release-backport-bot[bot]

Backport #8373 into stable2503 from lexnv.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-8373-to-stable2503
git worktree add --checkout .worktree/backport-8373-to-stable2503 backport-8373-to-stable2503
cd .worktree/backport-8373-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 9869517b4dc851469e6d854a263f82ff32133524
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 1, 2025
@github-actions github-actions bot requested a review from lexnv May 1, 2025 10:33
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv marked this pull request as ready for review May 1, 2025 10:51
Copy link
Contributor

github-actions bot commented May 1, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@lexnv
Copy link
Contributor

lexnv commented May 1, 2025

Tested the PR in versi-net (based on origin/master):

Synced a full node in Kusama directly from this branch, no warnings / errors encountered. The node is operating normally.

@lexnv lexnv assigned EgorPopelyaev and unassigned EgorPopelyaev May 1, 2025
@lexnv lexnv requested a review from EgorPopelyaev May 1, 2025 11:03
@EgorPopelyaev EgorPopelyaev enabled auto-merge (squash) May 1, 2025 11:36
@EgorPopelyaev EgorPopelyaev merged commit 7985777 into stable2503 May 1, 2025
378 of 388 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-8373-to-stable2503 branch May 1, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants