Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Modal Changes #413

Merged
merged 13 commits into from
Jan 15, 2025
Merged

SQL Modal Changes #413

merged 13 commits into from
Jan 15, 2025

Conversation

Koustavd18
Copy link
Contributor

@Koustavd18 Koustavd18 commented Jan 8, 2025

This PR will allow SQL Modal to retain context from filter builder and will also retain filter when console is refreshed

@Koustavd18 Koustavd18 marked this pull request as ready for review January 8, 2025 12:05
@Koustavd18 Koustavd18 self-assigned this Jan 8, 2025
@Koustavd18 Koustavd18 added bug Something isn't working Ready to merge PR is ready to review and merge console console/explore labels Jan 8, 2025
@Koustavd18 Koustavd18 marked this pull request as draft January 8, 2025 12:17
@Koustavd18 Koustavd18 removed the Ready to merge PR is ready to review and merge label Jan 8, 2025
@Koustavd18 Koustavd18 marked this pull request as ready for review January 13, 2025 15:18
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@praveen5959 praveen5959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Koustavd18 Koustavd18 added the Ready to merge PR is ready to review and merge label Jan 15, 2025
@nitisht nitisht merged commit 689593d into parseablehq:main Jan 15, 2025
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working console/explore console Ready to merge PR is ready to review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants