patricklx · patricklx · Mar 10, 2025
diff --git a/.eslintignore b/.eslintignore
@@ -14,8 +14,6 @@
 /packages/webpack/**/*.d.ts
 /packages/hbs-loader/**/*.js
 /packages/hbs-loader/**/*.d.ts
-/packages/broccoli-side-watch/**/*.js
-/packages/broccoli-side-watch/**/*.d.ts
 /test-packages/support/**/*.js
 /test-packages/**/*.d.ts
 /test-packages/release/src/*.js
@@ -64,3 +62,5 @@ package.json.ember-try
 #types added
 /types/**
 
+
+twsr
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,7 +8,8 @@ on:
   push:
     branches:
       - main
-  pull_request: {}
+  pull_request:
+    branches: [main]
 
 concurrency:
   group: ci-${{ github.head_ref || github.ref }}
@@ -45,14 +46,12 @@ jobs:
 
     steps:
       - uses: actions/checkout@v4
+      - name: Work around windows short path alias # https://github.com/actions/runner-images/issues/712
+        if: runner.os == 'Windows'
+        run: new-item D:\temp -ItemType Directory; new-item D:\.pnpm -ItemType Directory; echo "TEMP=D:\temp" >> $env:GITHUB_ENV; echo "PNPM_HOME=D:\.pnpm" >> $env:GITHUB_ENV
       - uses: ./.github/actions/setup
         with:
           use_lockfile: false
-      - name: Work around windows short path alias # https://github.com/actions/runner-images/issues/712
-        if: runner.os == 'Windows'
-        run: new-item D:\temp -ItemType Directory; echo "TEMP=D:\temp" >> $env:GITHUB_ENV
       - name: suite
         run: ${{ matrix.command }}
         working-directory: ${{ matrix.dir }}
-        env:
-          NODE_OPTIONS: "--max-old-space-size=8192"
diff --git a/.gitignore b/.gitignore
@@ -69,5 +69,3 @@ tests/scenarios/output/
 # Sys files
 .DS_Store
 *.swp
-
-/tsconfig.tsbuildinfo
diff --git a/.prettierignore b/.prettierignore
@@ -23,8 +23,6 @@
 /packages/webpack/**/*.d.ts
 /packages/hbs-loader/**/*.js
 /packages/hbs-loader/**/*.d.ts
-/packages/broccoli-side-watch/**/*.js
-/packages/broccoli-side-watch/**/*.d.ts
 /test-packages/support/**/*.js
 /test-packages/**/*.d.ts
 /test-packages/release/src/*.js

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,253 +1,5 @@
 # Embroider Changelog
 
-## Release (2024-11-11)
-
-@embroider/addon-dev 7.0.0 (major)
-
-#### :boom: Breaking Change
-* `@embroider/addon-dev`
-  * [#2166](https://github.com/embroider-build/embroider/pull/2166) Fix gjs/gts sourcemaps -- we accidentally unlocked really good DX ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
-
-#### Committers: 1
-- [@NullVoxPopuli](https://github.com/NullVoxPopuli)
-
-## Release (2024-11-05)
-
-@embroider/compat 3.7.0 (minor)
-
-#### :rocket: Enhancement
-* `@embroider/compat`
-  * [#2164](https://github.com/embroider-build/embroider/pull/2164) Support v2 ember-source ([@ef4](https://github.com/ef4))
-
-#### Committers: 1
-- Edward Faulkner ([@ef4](https://github.com/ef4))
-
-## Release (2024-10-31)
-
-@embroider/addon-shim 1.9.0 (minor)
-
-#### :rocket: Enhancement
-* `@embroider/addon-shim`
-  * [#2158](https://github.com/embroider-build/embroider/pull/2158) Add a new option for addon-shim to pass config to ember-auto-import ([@ef4](https://github.com/ef4))
-
-#### :house: Internal
-* `@embroider/test-scenarios`, `ts-app-template`
-  * [#2159](https://github.com/embroider-build/embroider/pull/2159) pinning @types/qunit to fix ci ([@ef4](https://github.com/ef4))
-
-#### Committers: 1
-- Edward Faulkner ([@ef4](https://github.com/ef4))
-
-## Release (2024-10-09)
-
-@embroider/compat 3.6.5 (patch)
-@embroider/core 3.4.19 (patch)
-@embroider/macros 1.16.9 (patch)
-@embroider/shared-internals 2.8.1 (patch)
-@embroider/webpack 4.0.8 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/shared-internals`
-  * [#2151](https://github.com/embroider-build/embroider/pull/2151) Fix hbs plugin not resolving .hbs due to broken Regex ([@simonihmig](https://github.com/simonihmig))
-
-#### Committers: 1
-- Simon Ihmig ([@simonihmig](https://github.com/simonihmig))
-
-## Release (2024-10-09)
-
-@embroider/broccoli-side-watch 1.0.1 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/broccoli-side-watch`
-  * [#2148](https://github.com/embroider-build/embroider/pull/2148) Fix broken default export when required from CJS ([@simonihmig](https://github.com/simonihmig))
-
-#### Committers: 1
-- Simon Ihmig ([@simonihmig](https://github.com/simonihmig))
-
-## Release (2024-10-09)
-
-@embroider/addon-dev 6.0.1 (patch)
-@embroider/broccoli-side-watch 1.0.0 (major)
-@embroider/compat 3.6.4 (patch)
-@embroider/core 3.4.18 (patch)
-@embroider/macros 1.16.8 (patch)
-@embroider/shared-internals 2.8.0 (minor)
-@embroider/webpack 4.0.7 (patch)
-
-#### :boom: Breaking Change
-* `@embroider/broccoli-side-watch`
-  * [#2146](https://github.com/embroider-build/embroider/pull/2146) Fix broccoli-side-watch so release-plan will release as 1.0.0 ([@simonihmig](https://github.com/simonihmig))
-
-#### :rocket: Enhancement
-* `@embroider/broccoli-side-watch`, `@embroider/shared-internals`
-  * [#2141](https://github.com/embroider-build/embroider/pull/2141) Add better broccoli-side-watch package ([@simonihmig](https://github.com/simonihmig))
-
-#### :bug: Bug Fix
-* `@embroider/addon-dev`, `@embroider/test-scenarios`
-  * [#2136](https://github.com/embroider-build/embroider/pull/2136) Enforce correct plugin order in addon-dev  ([@simonihmig](https://github.com/simonihmig))
-
-#### Committers: 1
-- Simon Ihmig ([@simonihmig](https://github.com/simonihmig))
-
-## Release (2024-10-08)
-
-@embroider/compat 3.6.3 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/compat`, `@embroider/test-scenarios`
-  * [#2133](https://github.com/embroider-build/embroider/pull/2133) fix typescript support for codemod and add option for renaming elements ([@void-mAlex](https://github.com/void-mAlex))
-  * [#2120](https://github.com/embroider-build/embroider/pull/2120) fix gts in v1 addons ([@patricklx](https://github.com/patricklx))
-
-#### :house: Internal
-* `@embroider/test-scenarios`
-  * [#2142](https://github.com/embroider-build/embroider/pull/2142) fixing test suite for ember >= 6 ([@ef4](https://github.com/ef4))
-
-#### Committers: 3
-- Alex ([@void-mAlex](https://github.com/void-mAlex))
-- Edward Faulkner ([@ef4](https://github.com/ef4))
-- Patrick Pircher ([@patricklx](https://github.com/patricklx))
-
-## Release (2024-10-01)
-
-@embroider/addon-dev 6.0.0 (major)
-@embroider/compat 3.6.2 (patch)
-@embroider/core 3.4.17 (patch)
-@embroider/macros 1.16.7 (patch)
-@embroider/shared-internals 2.7.0 (minor)
-@embroider/vite 0.2.1 (patch)
-@embroider/webpack 4.0.6 (patch)
-
-#### :boom: Breaking Change
-* `@embroider/addon-dev`, `@embroider/test-scenarios`
-  * [#2082](https://github.com/embroider-build/embroider/pull/2082) Hide base path from public URL of rollup-public-assets ([@simonihmig](https://github.com/simonihmig))
-
-#### :rocket: Enhancement
-* `@embroider/addon-dev`, `@embroider/shared-internals`, `@embroider/test-scenarios`
-  * [#2121](https://github.com/embroider-build/embroider/pull/2121) backport #1855 addon-dev: incremental updates to output ([@patricklx](https://github.com/patricklx))
-
-#### :bug: Bug Fix
-* `@embroider/compat`, `@embroider/core`, `@embroider/vite`, `@embroider/webpack`, `@embroider/test-scenarios`
-  * [#2127](https://github.com/embroider-build/embroider/pull/2127) Bump jsdom to fix punycode deprecation messages from tr46, psl, and whatwg-url ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
-* `@embroider/shared-internals`, `@embroider/test-scenarios`
-  * [#2122](https://github.com/embroider-build/embroider/pull/2122) speedup windows ci on stable ([@patricklx](https://github.com/patricklx))
-
-#### Committers: 3
-- Patrick Pircher ([@patricklx](https://github.com/patricklx))
-- Simon Ihmig ([@simonihmig](https://github.com/simonihmig))
-- [@NullVoxPopuli](https://github.com/NullVoxPopuli)
-
-## Release (2024-09-20)
-
-@embroider/core 3.4.16 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/core`, `@embroider/test-scenarios`
-  * [#2088](https://github.com/embroider-build/embroider/pull/2088) Implement ember's component-template-resolving deprecation ([@ef4](https://github.com/ef4))
-
-#### Committers: 1
-- Edward Faulkner ([@ef4](https://github.com/ef4))
-
-## Release (2024-08-30)
-
-@embroider/compat 3.6.1 (patch)
-@embroider/core 3.4.15 (patch)
-@embroider/macros 1.16.6 (patch)
-@embroider/shared-internals 2.6.3 (patch)
-@embroider/webpack 4.0.5 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/shared-internals`
-  * [#2075](https://github.com/embroider-build/embroider/pull/2075) Update ember standard modules to include @ember/renderer and @ember/-internals and ember-testing ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
-* `@embroider/compat`
-  * [#2067](https://github.com/embroider-build/embroider/pull/2067) codemod fixes ([@void-mAlex](https://github.com/void-mAlex))
-
-#### :memo: Documentation
-* [#2055](https://github.com/embroider-build/embroider/pull/2055) document templateTagCodemod usage ([@void-mAlex](https://github.com/void-mAlex))
-
-#### :house: Internal
-* `@embroider/webpack`
-  * [#2076](https://github.com/embroider-build/embroider/pull/2076) [Stable]: Follow upstream type change from webpack ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
-* Other
-  * [#2058](https://github.com/embroider-build/embroider/pull/2058) Set the packageManager field ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
-
-#### Committers: 2
-- Alex ([@void-mAlex](https://github.com/void-mAlex))
-- [@NullVoxPopuli](https://github.com/NullVoxPopuli)
-
-## Release (2024-07-18)
-
-@embroider/compat 3.6.0 (minor)
-
-#### :rocket: Enhancement
-* `@embroider/compat`, `@embroider/test-scenarios`
-  * [#1842](https://github.com/embroider-build/embroider/pull/1842) [beta] template-tag code mod ([@void-mAlex](https://github.com/void-mAlex))
-
-#### Committers: 1
-- Alex ([@void-mAlex](https://github.com/void-mAlex))
-
-## Release (2024-07-16)
-
-@embroider/compat 3.5.7 (patch)
-@embroider/util 1.13.2 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/compat`
-  * [#2033](https://github.com/embroider-build/embroider/pull/2033) Remove deprecations warnings in resolver transform ([@mkszepp](https://github.com/mkszepp))
-  * [#2047](https://github.com/embroider-build/embroider/pull/2047) Add semver to power select with create ([@mkszepp](https://github.com/mkszepp))
-
-#### :house: Internal
-* `@embroider/test-scenarios`
-  * [#1930](https://github.com/embroider-build/embroider/pull/1930) create a smoke test for the widest possible matrix ([@mansona](https://github.com/mansona))
-* Other
-  * [#2015](https://github.com/embroider-build/embroider/pull/2015) update github actions ([@mansona](https://github.com/mansona))
-* `@embroider/util`, `@embroider/sample-transforms`, `@embroider/test-support`, `@embroider/test-scenarios`
-  * [#1931](https://github.com/embroider-build/embroider/pull/1931) update scenario-tester ([@mansona](https://github.com/mansona))
-
-#### Committers: 2
-- Chris Manson ([@mansona](https://github.com/mansona))
-- Markus Sanin ([@mkszepp](https://github.com/mkszepp))
-
-## Release (2024-07-03)
-
-@embroider/compat 3.5.6 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/compat`
-  * [#2012](https://github.com/embroider-build/embroider/pull/2012) Empty packages as valid v2 addons ([@BlueCutOfficial](https://github.com/BlueCutOfficial))
-
-#### Committers: 1
-- Marine Dunstetter ([@BlueCutOfficial](https://github.com/BlueCutOfficial))
-
-## Release (2024-06-27)
-
-@embroider/addon-dev 5.0.0 (major)
-
-#### :boom: Breaking Change
-* `@embroider/addon-dev`
-  * [#2007](https://github.com/embroider-build/embroider/pull/2007) Add just the necessary files to rollup watch mode ([@vstefanovic97](https://github.com/vstefanovic97))
-
-#### Committers: 1
-- Vuk ([@vstefanovic97](https://github.com/vstefanovic97))
-
-## Release (2024-06-24)
-
-@embroider/compat 3.5.5 (patch)
-@embroider/core 3.4.14 (patch)
-@embroider/macros 1.16.5 (patch)
-@embroider/shared-internals 2.6.2 (patch)
-@embroider/webpack 4.0.4 (patch)
-
-#### :bug: Bug Fix
-* `@embroider/compat`, `@embroider/test-scenarios`
-  * [#2005](https://github.com/embroider-build/embroider/pull/2005) unique-id helper import based on ember-source version ([@void-mAlex](https://github.com/void-mAlex))
-
-#### :house: Internal
-* `@embroider/shared-internals`
-  * [#2000](https://github.com/embroider-build/embroider/pull/2000) Update typescript and fix issues with Typescript 5.5 ([@mansona](https://github.com/mansona))
-
-#### Committers: 2
-- Alex ([@void-mAlex](https://github.com/void-mAlex))
-- Chris Manson ([@mansona](https://github.com/mansona))
-
 ## Release (2024-06-20)
 
 @embroider/compat 3.5.4 (patch)

diff --git a/README.md b/README.md
@@ -117,33 +117,6 @@ return require('@embroider/compat').compatBuild(app, Webpack, {
 });
 ```
 
-## Template Tag Codemod
-
-Edit `ember-cli-build.js`:
-```js
-return require('@embroider/compat').templateTagCodemod(app, {
-  shouldTransformPath: (path) => { return true; },
-  nameHint: (path) => { 
-    // example path: shared/my-button
-    return path; 
-  },
-  dryRun: true,
-});
-```
-Run a normal ember build to transform your hbs templates into template tag single file components.
-Requires optimized build (static* flags to be turned on)
-
-### Options
-
-* `shouldTransformPath` - allows users to filter the templates that the code mod would run on
-* `nameHint` - optional function control the import name and template replacement values - valid JS identifier required or it will be coerced into one
-* `dryRun` - option can be used to obtain a summary of the changed the build would perform and which files it would act upon
-
-### Limitations
-
-* App templates only
-* `@embroider/compat` >= 3.6.0
-
 ## Compatibility
 
 ### Ember version

diff --git a/package.json b/package.json
@@ -58,7 +58,6 @@
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
   },
-  "packageManager": "pnpm@8.15.8+sha256.691fe176eea9a8a80df20e4976f3dfb44a04841ceb885638fe2a26174f81e65e",
   "changelog": {
     "__comment__": "Our release infrastructure relies on these exact labels. Be careful changing them.",
     "labels": {
@@ -70,5 +69,6 @@
       "unlabeled": ":question: Unlabeled"
     },
     "wildcardLabel": "unlabeled"
-  }
+  },
+  "packageManager": "pnpm@8.15.8+sha256.691fe176eea9a8a80df20e4976f3dfb44a04841ceb885638fe2a26174f81e65e"
 }
diff --git a/packages/addon-dev/README.md b/packages/addon-dev/README.md
@@ -22,26 +22,6 @@ For a guide on porting a V1 addon to V2, see https://github.com/embroider-build/
 
 A rollup plugin to expose a folder of assets. `path` is a required to define which folder to expose. `options.include` is a glob pattern passed to `walkSync.include` to pick files. `options.exlude` is a glob pattern passed to `walkSync.ignore` to exclude files. `options.namespace` is the namespace to expose files, defaults to the package name + the path that you provided e.g. if you call `addon.publicAssets('public')` in a v2 addon named `super-addon` then your namespace will default to `super-addon/public`.
 
-### addon.keepAssets(patterns: string[], exports?: 'default' | '*')
-
-A rollup plugin to preserve imports of non-Javascript assets unchanged in your published package. For example, the v2-addon-blueprint uses:
-
-```js
-addon.keepAssets(['**/*.css'])
-```
-
-so that the line `import "./my.css"` in your addon will be preserved and the corresponding CSS file will get included at the right path. 
-
-`keepAssets` is intended to compose correctly with other plugins that synthesize CSS imports, like `glimmer-scoped-css`. It will capture their output and produce real CSS files in your published package.
-
-The `exports` option defaults to `undefined` which means the assets are used for side-effect only and don't export any values. This is the supported way to use CSS in v2 addons. But you can also preserve assets that present themselves as having default exports with the value `"default"` or arbitrary named exports with the value `"*"`. For example:
-
-```js
-addon.keepAssets(["**/*.png"], "default")
-```
-
-lets you say `import imageURL from './my-image.png'`. Not that this pattern is **not** automatically supported in V2 addons and you would need to tell apps that consume your addon to handle it in a custom way.
-
 ## addon-dev command
 
 The `addon-dev` command helps with common tasks in v2 addons.