From b097c8f2d9d90156f2ddb07f7fde5019c6e1f852 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Tue, 15 Oct 2024 16:50:22 +0200 Subject: [PATCH 01/12] try --- .github/workflows/perf.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index 558ca08621..bc7567dead 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -43,6 +43,8 @@ jobs: - name: RUN if: steps.did-change.outputs.changed == 'true' + env: + NODE_OPTIONS: "--max-old-space-size=8192" run: pnpm run benchmark:setup - name: Remove unused artifacts From bb83b5beb8f936f540d4e5400e0cd25a600ecadf Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Tue, 15 Oct 2024 16:56:50 +0200 Subject: [PATCH 02/12] try --- .github/workflows/perf.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index bc7567dead..dc9aebc772 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -37,29 +37,25 @@ jobs: paths: packages/ - uses: wyvox/action-setup-pnpm@v3 - if: steps.did-change.outputs.changed == 'true' with: node-version: '20.1.0' - name: RUN - if: steps.did-change.outputs.changed == 'true' env: NODE_OPTIONS: "--max-old-space-size=8192" run: pnpm run benchmark:setup - name: Remove unused artifacts - if: steps.did-change.outputs.changed == 'true' run: rm -rf ./tracerbench-results/traces && rm -rf ./tracerbench-results/traces.zip - name: Upload Tracerbench Artifacts - if: steps.did-change.outputs.changed == 'true' && (failure() || success()) + if: (failure() || success()) uses: actions/upload-artifact@v3 with: name: Trace Artifacts path: tracerbench-results - name: Write message - if: steps.did-change.outputs.changed == 'true' uses: mshick/add-pr-comment@v2 with: message-path: "tracerbench-results/msg.txt" From 162f6a669d4531a9b12efb15b96e7c45057fed3a Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Tue, 15 Oct 2024 21:14:42 +0200 Subject: [PATCH 03/12] Update perf.yml --- .github/workflows/perf.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index dc9aebc772..6b7d6cd91c 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -36,6 +36,11 @@ jobs: with: paths: packages/ + - uses: browser-actions/setup-chrome@v1 + with: + chrome-version: 129 + install-chromedriver: true + - uses: wyvox/action-setup-pnpm@v3 with: node-version: '20.1.0' From 79e2e125fa2ea84dfe7d0a94ec8aaf834794f288 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Tue, 15 Oct 2024 22:39:23 +0200 Subject: [PATCH 04/12] Update perf.yml --- .github/workflows/perf.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index 6b7d6cd91c..dc9aebc772 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -36,11 +36,6 @@ jobs: with: paths: packages/ - - uses: browser-actions/setup-chrome@v1 - with: - chrome-version: 129 - install-chromedriver: true - - uses: wyvox/action-setup-pnpm@v3 with: node-version: '20.1.0' From a3d991b450afdde8398dbaba8a2c7a5616ac17f6 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Tue, 15 Oct 2024 22:50:22 +0200 Subject: [PATCH 05/12] Update package.json --- package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package.json b/package.json index b67affc741..931867560e 100644 --- a/package.json +++ b/package.json @@ -126,6 +126,9 @@ "node": "20.9.0", "pnpm": "8.5.0" }, + "pcr": { + "revision": "5866970" + }, "pnpm": { "overrides": { "@rollup/pluginutils": "^5.0.2", From 84217952cd661413d114b156ab3b5a2c8fb8c470 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Tue, 15 Oct 2024 23:34:22 +0200 Subject: [PATCH 06/12] Update perf.yml --- .github/workflows/perf.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index dc9aebc772..7398b472bf 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -15,6 +15,7 @@ concurrency: cancel-in-progress: true env: + PUPPETEER_SKIP_DOWNLOAD: true EXPERIMENT_BRANCH_NAME: ${{ github.head_ref || github.ref_name }} CONTROL_BRANCH_NAME: 'main' FIDELITY: 100 From c5262e7e6fee08387877c4c056ff83bd54628020 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Wed, 16 Oct 2024 08:50:26 +0200 Subject: [PATCH 07/12] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 931867560e..7470673893 100644 --- a/package.json +++ b/package.json @@ -123,7 +123,7 @@ }, "packageManager": "pnpm@8.5.0", "volta": { - "node": "20.9.0", + "node": "22.9.0", "pnpm": "8.5.0" }, "pcr": { From 09830053f735983cd91086fc5e2de2039da6ab2e Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Wed, 16 Oct 2024 08:51:27 +0200 Subject: [PATCH 08/12] Update perf.yml --- .github/workflows/perf.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index 7398b472bf..1ebc7c374e 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -39,7 +39,7 @@ jobs: - uses: wyvox/action-setup-pnpm@v3 with: - node-version: '20.1.0' + node-version: '22.9.0' - name: RUN env: From ef7e6464323c9dca722278af81d5a2f3eac2fa79 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Wed, 16 Oct 2024 09:06:00 +0200 Subject: [PATCH 09/12] Update perf.yml --- .github/workflows/perf.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index 1ebc7c374e..ae8aa7a8a7 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -39,7 +39,7 @@ jobs: - uses: wyvox/action-setup-pnpm@v3 with: - node-version: '22.9.0' + node-version: '19' - name: RUN env: From 74e870efd3b29944a532f7764ae83c00acd4c1ca Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Wed, 16 Oct 2024 09:45:45 +0200 Subject: [PATCH 10/12] try --- .github/workflows/perf.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index ae8aa7a8a7..24871efe8a 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -39,11 +39,12 @@ jobs: - uses: wyvox/action-setup-pnpm@v3 with: - node-version: '19' + node-version: '20' - name: RUN env: NODE_OPTIONS: "--max-old-space-size=8192" + NODE_DEBUG: "*" run: pnpm run benchmark:setup - name: Remove unused artifacts From 0f8aaa16d42297d1fd6aa15d7dcff8d3cac38ee5 Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Wed, 16 Oct 2024 10:40:31 +0200 Subject: [PATCH 11/12] Update perf.yml --- .github/workflows/perf.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index 24871efe8a..e64918534a 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -39,12 +39,11 @@ jobs: - uses: wyvox/action-setup-pnpm@v3 with: - node-version: '20' + node-version: '18' - name: RUN env: NODE_OPTIONS: "--max-old-space-size=8192" - NODE_DEBUG: "*" run: pnpm run benchmark:setup - name: Remove unused artifacts From b1c953b9c730fc1163cbd31a5bcf6b9ac8ebb34b Mon Sep 17 00:00:00 2001 From: Patrick Pircher Date: Wed, 16 Oct 2024 10:52:14 +0200 Subject: [PATCH 12/12] Update setup-bench.mjs --- bin/setup-bench.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/setup-bench.mjs b/bin/setup-bench.mjs index eee3ffd1d8..40d5378a35 100644 --- a/bin/setup-bench.mjs +++ b/bin/setup-bench.mjs @@ -174,7 +174,7 @@ await new Promise((resolve) => { try { const output = - await $`./node_modules/.bin/tracerbench compare --regressionThreshold 25 --sampleTimeout 60 --fidelity ${fidelity} --markers ${markers} --controlURL ${CONTROL_URL} --experimentURL ${EXPERIMENT_URL} --report --headless --cpuThrottleRate ${throttleRate}`; + await $`node --single-threaded-gc ./node_modules/tracerbench/bin/run compare --regressionThreshold 25 --sampleTimeout 60 --fidelity ${fidelity} --markers ${markers} --controlURL ${CONTROL_URL} --experimentURL ${EXPERIMENT_URL} --report --headless --cpuThrottleRate ${throttleRate}`; try { fs.writeFileSync(