Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 13 #6

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
f2fae59
Move prettier tests to the smoke-tests project
NullVoxPopuli Mar 4, 2025
ce66b21
Update lockfile
NullVoxPopuli Mar 4, 2025
86d6fd8
x
NullVoxPopuli Mar 4, 2025
0b7e74a
ope
NullVoxPopuli Mar 4, 2025
ac8d728
Merge pull request #1726 from glimmerjs/put-prettier-testing-in-the-s…
NullVoxPopuli Mar 4, 2025
6915f8c
Update release-plan
NullVoxPopuli Mar 4, 2025
7ed9e1a
Don't forget repo meta update
NullVoxPopuli Mar 4, 2025
e7c69f2
Printer bug: empty string literal args are dropped
ef4 Feb 28, 2025
948a249
proposed fix
ef4 Mar 3, 2025
ef65598
lint:fix
NullVoxPopuli Mar 4, 2025
ad33f94
Merge pull request #1727 from glimmerjs/update-release-plan
NullVoxPopuli Mar 4, 2025
542d4f0
Merge pull request #1722 from glimmerjs/printer-empty-string-literal
NullVoxPopuli Mar 4, 2025
fda31c1
Set node-version to 22
NullVoxPopuli Mar 4, 2025
f06a2fb
Merge pull request #1728 from glimmerjs/set-node-version-to-22
NullVoxPopuli Mar 4, 2025
c7b3aef
Prepare Release using 'release-plan'
NullVoxPopuli Mar 4, 2025
351071e
Merge pull request #1715 from glimmerjs/release-preview
NullVoxPopuli Mar 4, 2025
eba150d
Revert "Prepare Release"
NullVoxPopuli Mar 4, 2025
0f3c87f
Merge pull request #1729 from glimmerjs/revert-1715-release-preview
NullVoxPopuli Mar 4, 2025
f618497
Go back to using configs from before #1727
NullVoxPopuli Mar 4, 2025
20cbe3e
Merge pull request #1730 from glimmerjs/fix-release-plan
NullVoxPopuli Mar 4, 2025
c6e3110
Prepare Release using 'release-plan'
NullVoxPopuli Mar 4, 2025
426b32c
Merge pull request #1731 from glimmerjs/release-preview
NullVoxPopuli Mar 4, 2025
8af31ce
Fix bench post-install
NullVoxPopuli Mar 4, 2025
d407ff4
ignore-workspace -> ignore-workspace-root-check
NullVoxPopuli Mar 4, 2025
7050f70
Force CI=false for bench
NullVoxPopuli Mar 4, 2025
1f61e5a
Update bench-packages.mts
NullVoxPopuli Mar 5, 2025
bdb1cbf
Use postinstall script to opt out of postinstall
NullVoxPopuli Mar 5, 2025
a724e82
+x
NullVoxPopuli Mar 5, 2025
1e2cace
bah
NullVoxPopuli Mar 5, 2025
5474c62
Merge pull request #1732 from glimmerjs/fix-post-install
NullVoxPopuli Mar 5, 2025
3ddb96a
Restore {{debugger}} behavior
NullVoxPopuli Mar 14, 2025
27b58b3
Merge pull request #1734 from glimmerjs/restore-debugger
NullVoxPopuli Mar 14, 2025
135dd10
Prepare Release using 'release-plan'
NullVoxPopuli Mar 14, 2025
550d1f0
Manually update the release-preview to force @glimmer/runtime to release
NullVoxPopuli Mar 14, 2025
96e24af
Add pkgJSONPath
NullVoxPopuli Mar 14, 2025
da82284
Add constraints array (empty)
NullVoxPopuli Mar 14, 2025
f92aa4f
Add entry to constraints arary
NullVoxPopuli Mar 14, 2025
7c567f6
Add impact
NullVoxPopuli Mar 14, 2025
01d1e97
Merge pull request #1733 from glimmerjs/release-preview
NullVoxPopuli Mar 14, 2025
405131e
Force release
NullVoxPopuli Mar 14, 2025
3011058
Merge pull request #1735 from glimmerjs/force-release
NullVoxPopuli Mar 14, 2025
8495c47
pnpm repo:update:metadata
NullVoxPopuli Mar 15, 2025
33dad1f
Merge pull request #1736 from glimmerjs/nvp/update-meta
NullVoxPopuli Mar 15, 2025
ab0c666
Removing editor.rulers
ef4 Mar 15, 2025
809e52a
Merge pull request #1738 from glimmerjs/editor-rulers
NullVoxPopuli Mar 15, 2025
70e1f99
Re-add package.json#types for tsconfig's moduleResolution=node10
NullVoxPopuli Mar 18, 2025
0a3b180
Merge pull request #1741 from glimmerjs/add-back-types-for-moduleReso…
NullVoxPopuli Mar 18, 2025
a289509
Prepare Release using 'release-plan'
NullVoxPopuli Mar 18, 2025
b62c608
Merge pull request #1737 from glimmerjs/release-preview
NullVoxPopuli Mar 18, 2025
5de5cdd
Upgrade handlebars parser
NullVoxPopuli Mar 20, 2025
a1eb2b3
Upgrade to nppm 10.6.5
NullVoxPopuli Mar 20, 2025
7ab5074
Merge pull request #1743 from glimmerjs/upgrade-handlebars-parser
NullVoxPopuli Mar 20, 2025
3197d5f
Merge pull request #1744 from glimmerjs/nvp/update-pnpm
NullVoxPopuli Mar 20, 2025
9f05c60
test
patricklx Mar 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions .github/workflows/plan-release.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Release Plan Review
name: Plan Release
on:
workflow_dispatch:
push:
branches:
- main
Expand All @@ -14,36 +15,34 @@ concurrency:
cancel-in-progress: true

jobs:
check-plan:
name: "Check Release Plan"
is-this-a-release:
name: "Is this a release?"
runs-on: ubuntu-latest
outputs:
command: ${{ steps.check-release.outputs.command }}

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-depth: 2
ref: 'main'
# This will only cause the `check-plan` job to have a "command" of `release`
# This will only cause the `is-this-a-release` job to have a "command" of `release`
# when the .release-plan.json file was changed on the last commit.
- id: check-release
run: if git diff --name-only HEAD HEAD~1 | grep -w -q ".release-plan.json"; then echo "command=release"; fi >> $GITHUB_OUTPUT

prepare_release_notes:
name: Prepare Release Notes
create-prepare-release-pr:
name: Create Prepare Release PR
runs-on: ubuntu-latest
timeout-minutes: 5
needs: check-plan
needs: is-this-a-release
permissions:
contents: write
issues: read
pull-requests: write
outputs:
explanation: ${{ steps.explanation.outputs.text }}
# only run on push event if plan wasn't updated (don't create a release plan when we're releasing)
# only run on push event or workflow dispatch if plan wasn't updated (don't create a release plan when we're releasing)
# only run on labeled event if the PR has already been merged
if: (github.event_name == 'push' && needs.check-plan.outputs.command != 'release') || (github.event_name == 'pull_request_target' && github.event.pull_request.merged == true)
if: ((github.event_name == 'push' || github.event_name == 'workflow_dispatch') && needs.is-this-a-release.outputs.command != 'release') || (github.event_name == 'pull_request_target' && github.event.pull_request.merged == true)

steps:
- uses: actions/checkout@v4
Expand All @@ -54,26 +53,31 @@ jobs:
ref: 'main'
- uses: wyvox/action-setup-pnpm@v3
with:
# We have to keep ignore-scripts so that we skip post-install.
# Post-install won't pass on CI and is meant for local smoke tests
args: '--ignore-scripts'
node-version: 22.13.0

- name: "Generate Explanation and Prep Changelogs"
id: explanation
run: |
# Original Content Here
# Original content here
set +e
pnpm release-plan prepare 2> >(tee -a release-plan-stderr.txt >&2)

if [ $? -ne 0 ]; then
echo 'text<<EOF' >> $GITHUB_OUTPUT
cat release-plan-stderr.txt >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
release_plan_output=$(cat release-plan-stderr.txt)
else
echo 'text<<EOF' >> $GITHUB_OUTPUT
jq .description .release-plan.json -r >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
release_plan_output=$(jq .description .release-plan.json -r)
rm release-plan-stderr.txt

if [ $(jq '.solution | length' .release-plan.json) -eq 1 ]; then
new_version=$(jq -r '.solution[].newVersion' .release-plan.json)
echo "new_version=v$new_version" >> $GITHUB_OUTPUT
fi
fi
echo 'text<<EOF' >> $GITHUB_OUTPUT
echo "$release_plan_output" >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT

# Don't forget to-re-add these when we update release-plan
pnpm repo:update:conventions
Expand All @@ -82,12 +86,12 @@ jobs:
env:
GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}

- uses: peter-evans/create-pull-request@v6
- uses: peter-evans/create-pull-request@v7
with:
commit-message: "Prepare Release using 'release-plan'"
commit-message: "Prepare Release ${{ steps.explanation.outputs.new_version}} using 'release-plan'"
labels: "internal"
branch: release-preview
title: Prepare Release
title: Prepare Release ${{ steps.explanation.outputs.new_version }}
body: |
This PR is a preview of the release that [release-plan](https://github.com/embroider-build/release-plan) has prepared. To release you should just merge this PR 👍

Expand Down
39 changes: 8 additions & 31 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# For every push to the master branch, this checks if the release-plan was
# updated and if it was it will publish stable npm packages based on the
# release plan
# For every push to the primary branch with .release-plan.json modified,
# runs release-plan.

name: Publish Stable

Expand All @@ -10,55 +9,33 @@ on:
branches:
- main
- master
paths:
- '.release-plan.json'

concurrency:
group: publish-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
check-plan:
name: "Check Release Plan"
runs-on: ubuntu-latest
outputs:
command: ${{ steps.check-release.outputs.command }}

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
ref: 'main'
# This will only cause the `check-plan` job to have a result of `success`
# when the .release-plan.json file was changed on the last commit. This
# plus the fact that this action only runs on main will be enough of a guard
- id: check-release
run: if git diff --name-only HEAD HEAD~1 | grep -w -q ".release-plan.json"; then echo "command=release"; fi >> $GITHUB_OUTPUT

publish:
name: "NPM Publish"
runs-on: ubuntu-latest
needs: check-plan
if: needs.check-plan.outputs.command == 'release'
permissions:
contents: write
pull-requests: write
id-token: write
attestations: write

steps:
- uses: actions/checkout@v4

- name: 'Setup local TurboRepo server'
uses: felixmosh/turborepo-gh-artifacts@v2
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- uses: wyvox/action-setup-pnpm@v3
with:
args: '--ignore-scripts'
node-version: 22.13.0
# This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable
node-registry-url: 'https://registry.npmjs.org'

- name: npm publish
run: pnpm release-plan publish
- name: Publish to NPM
run: NPM_CONFIG_PROVENANCE=true pnpm release-plan publish
env:
GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
1 change: 1 addition & 0 deletions .meta-updater/main.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export default () =>
},
});
} else {
update(publishConfig, 'types', 'dist/dev/index.d.ts');
update(publishConfig, 'exports', {
'.': {
development: {
Expand Down
Loading
Loading